Io socket handle for internal socket#13418
Closed
lambdai wants to merge 98 commits intoenvoyproxy:mainfrom
Closed
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close in favor of #14712 and #14917
Commit Message:
Introduce BufferedIoSocketHandleImpl and UserSpaceFileEventImpl.
This socket handle owns the buffer for itself to read data from and for the peer to write to.
UserSpaceFileEventImpl is the FileEvent this socket could work with.
UserSpaceFileEventImpl provides 3 functions
eventsare registered for callback. Each call detects fired events once, and IO handle will notify the new events in the long run.activate, poll honors thesetEnabled.The BufferedIoSocketHandleImpl work with ConnectionImpl, and TcpListenerFilter
fdDoNotUseThe high level socket option should be intercepted by ConnectionSocketinstead of accessing the fd.
Will provide the example of
ConnectionImplandConnectionSocketin the next PR.Additional Description:
Extracted from #13361
Risk Level: Low. Production is not using this socket.
Testing: Added unit test.
Docs Changes: N/A
Release Notes: N/A