grpc: officially deprecate Grpc::RpcChannelImpl and remove in 1.4.0.#1426
Merged
htuch merged 1 commit intoenvoyproxy:masterfrom Aug 10, 2017
Merged
grpc: officially deprecate Grpc::RpcChannelImpl and remove in 1.4.0.#1426htuch merged 1 commit intoenvoyproxy:masterfrom
htuch merged 1 commit intoenvoyproxy:masterfrom
Conversation
This will resolve envoyproxy#1102 when we remove the files, there are no longer any uses of this within the main Envoy repo, so this exists solely for consuming projects.
mattklein123
approved these changes
Aug 10, 2017
nezdolik
pushed a commit
to nezdolik/envoy
that referenced
this pull request
May 4, 2024
We used msync to verify that address is readable. But msync gives false positives for PROT_NONE mappings. And we recently got bug report from user hitting this exact condition. For correct access check, we steal idea from Abseil and do sigprocmask with address used as new signal mask and with invalid HOW argument. This works in today's Linux kernels and is among fastest methods available. But is brittle w.r.t. possible kernel changes. So we supply fallback method that does 2 syscalls. For non-Linux systems we implement usual "write to pipe" trick. Which also has decent performance, but requires occasional pipe draining and uses fds which could occasionally be damaged by some forking codes. We also finally cover all new code with unit test. Fixes github issue envoyproxy#1426
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will resolve #1102 when we remove the files, there are no longer any uses of this within the
main Envoy repo, so this exists solely for consuming projects.