Skip to content

grpc: officially deprecate Grpc::RpcChannelImpl and remove in 1.4.0.#1426

Merged
htuch merged 1 commit intoenvoyproxy:masterfrom
htuch:rpc-channel-deprecate
Aug 10, 2017
Merged

grpc: officially deprecate Grpc::RpcChannelImpl and remove in 1.4.0.#1426
htuch merged 1 commit intoenvoyproxy:masterfrom
htuch:rpc-channel-deprecate

Conversation

@htuch
Copy link
Copy Markdown
Member

@htuch htuch commented Aug 10, 2017

This will resolve #1102 when we remove the files, there are no longer any uses of this within the
main Envoy repo, so this exists solely for consuming projects.

This will resolve envoyproxy#1102 when we remove the files, there are no longer any uses of this within the
main Envoy repo, so this exists solely for consuming projects.
@htuch htuch merged commit 30ab1c7 into envoyproxy:master Aug 10, 2017
@htuch htuch deleted the rpc-channel-deprecate branch August 10, 2017 14:50
nezdolik pushed a commit to nezdolik/envoy that referenced this pull request May 4, 2024
We used msync to verify that address is readable. But msync gives
false positives for PROT_NONE mappings. And we recently got bug report
from user hitting this exact condition.

For correct access check, we steal idea from Abseil and do sigprocmask
with address used as new signal mask and with invalid HOW
argument. This works in today's Linux kernels and is among fastest
methods available. But is brittle w.r.t. possible kernel changes. So
we supply fallback method that does 2 syscalls.

For non-Linux systems we implement usual "write to pipe" trick. Which
also has decent performance, but requires occasional pipe draining and
uses fds which could occasionally be damaged by some forking codes.

We also finally cover all new code with unit test.

Fixes github issue envoyproxy#1426
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate RpcChannel for unary gRPC

2 participants