Skip to content

fix sds_dynamic_key_rotation_setup.sh running from other repos#14086

Merged
htuch merged 1 commit intoenvoyproxy:masterfrom
lizan:fix_sds_test_external
Nov 19, 2020
Merged

fix sds_dynamic_key_rotation_setup.sh running from other repos#14086
htuch merged 1 commit intoenvoyproxy:masterfrom
lizan:fix_sds_test_external

Conversation

@lizan
Copy link
Copy Markdown
Member

@lizan lizan commented Nov 18, 2020

Signed-off-by: Lizan Zhou lizan@tetrate.io

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan lizan requested a review from htuch November 18, 2020 23:39
Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@htuch htuch merged commit 9ccd778 into envoyproxy:master Nov 19, 2020
@lizan lizan deleted the fix_sds_test_external branch November 19, 2020 07:10
andreyprezotto pushed a commit to andreyprezotto/envoy that referenced this pull request Nov 24, 2020
qqustc pushed a commit to qqustc/envoy that referenced this pull request Nov 24, 2020
…proxy#14086)

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Qin Qin <qqin@google.com>
htuch pushed a commit that referenced this pull request Nov 24, 2020
- Always exercise the code path that using filter-example to test Envoy, to catch issues like #14086 in CI.
- Removed no longer existing legacy_codecs_in_integration_tests definition.

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants