ci: compile_time_options fixes#14105
Merged
htuch merged 2 commits intoenvoyproxy:masterfrom Nov 24, 2020
Merged
Conversation
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Member
|
/cc @rojkov |
htuch
reviewed
Nov 23, 2020
| TEST_TARGETS=("@envoy//test/...") | ||
| fi | ||
| cd "${ENVOY_FILTER_EXAMPLE_SRCDIR}" | ||
| TEST_TARGETS=("${TEST_TARGETS[@]/#\/\//@envoy\/\/}") |
Member
There was a problem hiding this comment.
When running do_ci.sh with just a single test target for compile_time_options, does this force all the filter example tests as well?
Member
There was a problem hiding this comment.
The flow is often that a developer just wants to run a single quick test, why force them to run additional tests?
Member
Author
There was a problem hiding this comment.
Ah I read the first comment wrong, it runs the single test from filter example, but doesn't run additional tests.
For example, if specified test is
//test/common/common:base64_test, this will run it as @envoy//test/common/common:base64_test from filter example repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
legacy_codecs_in_integration_testsdefinition.Signed-off-by: Lizan Zhou lizan@tetrate.io