apple dns: add fake api test suite#13780
Merged
junr03 merged 4 commits intoenvoyproxy:masterfrom Oct 28, 2020
junr03:apple-dns-test-suite
Merged
apple dns: add fake api test suite#13780junr03 merged 4 commits intoenvoyproxy:masterfrom junr03:apple-dns-test-suite
junr03 merged 4 commits intoenvoyproxy:masterfrom
junr03:apple-dns-test-suite
Conversation
Signed-off-by: Jose Nino <jnino@lyft.com>
junr03
commented
Oct 27, 2020
Member
Author
|
@mattklein123 I am pleased about how this turned out! As I was writing tests I thought about a couple behaviors that are not necessarily wrong or right but wanted to hear what you thought about them -- I have marked them with and inline comment that starts with Unfortunately running coverage with bazel in MacOS is a mess (bazelbuild/bazel#10457) so I was unable to run an actual coverage report. I inspected the code and believe I have covered all branches, but if you spot anything you'd like to see a test on lmk. |
mattklein123
requested changes
Oct 27, 2020
Member
mattklein123
left a comment
There was a problem hiding this comment.
Thanks very nice. Excited to see better tests here. Some small comments and also needs a format fix.
/wait
added 3 commits
October 27, 2020 18:07
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Oct 30, 2020
* master: (83 commits) tls: Typesafe tls slots (envoyproxy#13789) docs(example): Correct URL for caching example page (envoyproxy#13810) [fuzz] Made health check fuzz more efficient (envoyproxy#13747) rtds: properly scope rtds stats (envoyproxy#13764) http: fixing a bug with IPv6 hosts (envoyproxy#13798) connection: Remember transport socket read resumption requests and replay them when re-enabling read. (envoyproxy#13772) network: adding some accessors for ALPN work. (envoyproxy#13785) docs: added a step about how to handle platform specific extensions (envoyproxy#13759) Fix identation in ip transparency code snippet (envoyproxy#13743) wasm: enable WAVM's stack unwinding feature (envoyproxy#13792) log: set route name for direct response (envoyproxy#13683) Use nghttp2 as external dependsncy in protocol_constraints_lib (envoyproxy#13763) [Windows] Update windows dev docs (envoyproxy#13741) cel: patch thread safety issue (envoyproxy#13739) Windows: Fix ssl_socket_test (envoyproxy#13264) apple dns: add fake api test suite (envoyproxy#13780) overload: scale selected timers in response to load (envoyproxy#13475) examples: Add dynamic configuration (control plane) sandbox (envoyproxy#13746) Removed exception in getResponseStatus() (envoyproxy#13314) network: add timeout for transport connect (envoyproxy#13610) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: apple dns - add fake api test suite
Additional Description: use a singleton to inject a mock class for Apple's API calls during testing. This allows for finer control for error paths and callback firing.
Risk Level: low - more test coverage
Testing: adds new unit test suite
Signed-off-by: Jose Nino jnino@lyft.com