log: set route name for direct response#13683
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Oct 28, 2020
Merged
Conversation
Signed-off-by: Kuat Yessenov <kuat@google.com>
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines. |
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines. |
dio
suggested changes
Oct 26, 2020
Member
dio
left a comment
There was a problem hiding this comment.
Looks good. Do you think this is a good opportunity to expand docs on docs/root/intro/arch_overview/http/http_routing.rst. At the Direct responses section that we have full log information when it happens?
| // Content-length header is correct. | ||
| EXPECT_EQ("0", response->headers().getContentLengthValue()); | ||
|
|
||
| std::string log = waitForAccessLog(access_log_name_); |
Contributor
Author
|
@dio I think it's a given that direct response should not be any different than other route actions. I consider this a regression fix. |
kyessenov
added a commit
to istio/envoy
that referenced
this pull request
Oct 28, 2020
Signed-off-by: Kuat Yessenov <kuat@google.com>
istio-testing
pushed a commit
to istio/envoy
that referenced
this pull request
Oct 28, 2020
Signed-off-by: Kuat Yessenov <kuat@google.com>
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Oct 30, 2020
* master: (83 commits) tls: Typesafe tls slots (envoyproxy#13789) docs(example): Correct URL for caching example page (envoyproxy#13810) [fuzz] Made health check fuzz more efficient (envoyproxy#13747) rtds: properly scope rtds stats (envoyproxy#13764) http: fixing a bug with IPv6 hosts (envoyproxy#13798) connection: Remember transport socket read resumption requests and replay them when re-enabling read. (envoyproxy#13772) network: adding some accessors for ALPN work. (envoyproxy#13785) docs: added a step about how to handle platform specific extensions (envoyproxy#13759) Fix identation in ip transparency code snippet (envoyproxy#13743) wasm: enable WAVM's stack unwinding feature (envoyproxy#13792) log: set route name for direct response (envoyproxy#13683) Use nghttp2 as external dependsncy in protocol_constraints_lib (envoyproxy#13763) [Windows] Update windows dev docs (envoyproxy#13741) cel: patch thread safety issue (envoyproxy#13739) Windows: Fix ssl_socket_test (envoyproxy#13264) apple dns: add fake api test suite (envoyproxy#13780) overload: scale selected timers in response to load (envoyproxy#13475) examples: Add dynamic configuration (control plane) sandbox (envoyproxy#13746) Removed exception in getResponseStatus() (envoyproxy#13314) network: add timeout for transport connect (envoyproxy#13610) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kuat Yessenov kuat@google.com
Commit Message: set route name in direct response, so it can be used in logging
Additional Description:
Risk Level: low (regression fix)
Testing: integration
Docs Changes: none
Release Notes: none
Fixes: #13157