protobuf: update for google import#1321
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Jul 25, 2017
Merged
Conversation
hennna
commented
Jul 24, 2017
| Http::Utility::sendLocalReply(*decoder_callbacks_, stream_reset_, Http::Code::BadRequest, | ||
| request_status.error_message().ToString()); | ||
| request_status.error_message()); | ||
|
|
Contributor
Author
Member
There was a problem hiding this comment.
I think so if this is already a std::string.
htuch
reviewed
Jul 24, 2017
| if (!request_status.ok()) { | ||
| ENVOY_LOG(debug, "Transcoding request error " + request_status.ToString()); | ||
| ENVOY_LOG(debug, "Transcoding request error " + | ||
| ProtobufTypes::FromString(request_status.ToString())); |
Member
There was a problem hiding this comment.
This seems an identity function..
| Http::Utility::sendLocalReply(*decoder_callbacks_, stream_reset_, Http::Code::BadRequest, | ||
| request_status.error_message().ToString()); | ||
| request_status.error_message()); | ||
|
|
Member
There was a problem hiding this comment.
I think so if this is already a std::string.
| if (!request_status.ok()) { | ||
| ENVOY_LOG(debug, "Transcoding request error " + request_status.ToString()); | ||
| ENVOY_LOG(debug, | ||
| "Transcoding request error " + ProtobufTypes::FromString(request_status.ToString())); |
Contributor
Author
There was a problem hiding this comment.
Do you mean just can just have request_status without to and from string conversions?
Member
There was a problem hiding this comment.
Why would you convert std::string to Protobuf::String and then back in the same expression?
Contributor
Author
There was a problem hiding this comment.
My understanding is that this is util::Status -> Protobuf::String -> std::string.
|
|
||
| "admin": { "access_log_path": "/dev/null", "address": "tcp://{{ ip_loopback_address }}:0" }, | ||
| "statsd_local_udp_port": 8125, | ||
| "statsd_udp_ip_address": "{{ ip_loopback_address }}:8125", |
Contributor
Author
There was a problem hiding this comment.
Not protobuf related but this test fails in IPv6 only environments.
htuch
approved these changes
Jul 25, 2017
mattklein123
approved these changes
Jul 25, 2017
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
Automatic merge from submit-queue. Sanitize JWT verification result in HTTP headers **What this PR does / why we need it**: To defend the attack of injecting forged JWT verification results in HTTP headers, sanitize the JWT verification result when jwt_auth filter starts. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes envoyproxy#1321 **Special notes for your reviewer**: **Release note**: ```release-note ```
nezdolik
pushed a commit
to nezdolik/envoy
that referenced
this pull request
May 4, 2024
mathetake
pushed a commit
that referenced
this pull request
Mar 3, 2026
**Description** AWS knowledge MCP server is subject to rate limits which causes flakey tests. If we need another public MCP, there are 39 others not including shopify sites. **Related Issues/PRs (if applicable)** Fixes #1320 Signed-off-by: Adrian Cole <adrian@tetrate.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows mapping from protobuf::util to other util namespaces in addition to plumbing through some other protobuf related mapping. Also one IPv6 related change. Needed for google import.