Conversation
ci/ci_steps.sh
Outdated
| ./ci/docker_push.sh | ||
| # This script runs on every PRs release run to test the docker examples. | ||
| ./ci/verify_examples.sh | ||
| if [ "$TRAVIS_PULL_REQUEST" == "false" ] && [ "$TRAVIS_BRANCH" == "master" ] |
There was a problem hiding this comment.
Doesn't docker_push.sh also do stuff? Should the guard go around both?
There was a problem hiding this comment.
It does, and it already has a guard there. Although you reminded me that we did some work there on every PR only because the images build on docker_push.sh were needed for verification. Now that we only verify on master, we can move those build into the master guard; re: second commit.
There was a problem hiding this comment.
nit: I was mainly commenting that we have guarding in multiple places, which is confusing. Can we just guard in this file and not in the called scripts? Or just there?
There was a problem hiding this comment.
Your teachings are definitely permeating into my brain! At the same time you wrote this comment, I pushed the latest commit. I moved the verification into the docker_push file. As you said, no reason to have the guards in different places.
ci/ci_steps.sh
Outdated
| @@ -37,8 +37,6 @@ else | |||
| cp -f "$ENVOY_BUILD_DIR"/envoy/source/exe/envoy ./build_release | |||
| # This script builds a lyft/envoy image and pushes that image on merge to master. | |||
There was a problem hiding this comment.
nit: This comment is out of date now.
**Description** AWS knowledge MCP server is subject to rate limits which causes flakey tests. If we need another public MCP, there are 39 others not including shopify sites. **Related Issues/PRs (if applicable)** Fixes #1320 Signed-off-by: Adrian Cole <adrian@tetrate.io>
@mattklein123 @htuch move docker sandboxes verifications to only run on master commits.