Merged
Conversation
c6a6a51 to
f69e6a5
Compare
d3300b6 to
f5ced76
Compare
Signed-off-by: Ryan Northey <ryan@synca.io>
f5ced76 to
73a3b8e
Compare
zuercher
previously approved these changes
Sep 10, 2020
Member
zuercher
left a comment
There was a problem hiding this comment.
Thanks!
Are these confirmed to work on the older version of bash that ends up being used on macOS by some folks during development?
Member
Author
|
i dont have immediate access to any legacy operating systems. If you can tell me which |
phlax
commented
Sep 10, 2020
phlax
commented
Sep 10, 2020
phlax
commented
Sep 10, 2020
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
commented
Sep 10, 2020
phlax
commented
Sep 10, 2020
phlax
commented
Sep 10, 2020
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
commented
Sep 10, 2020
Signed-off-by: Ryan Northey <ryan@synca.io>
Member
Author
|
@zuercher i think this is ready for review again |
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
zuercher
approved these changes
Sep 11, 2020
Member
zuercher
left a comment
There was a problem hiding this comment.
Thanks for checking. I'm ok to go ahead with this.
lhluo
pushed a commit
to lhluo/envoy
that referenced
this pull request
Sep 11, 2020
…code * upstream/master: lint: add more linters for using absl:: over std:: (envoyproxy#13043) udpa: filesystem list collection support for inline entries. (envoyproxy#13028) filter: http: jwt: implement matching for HTTP CONNECT (envoyproxy#13064) [fuzz] split http filter logic into a fuzzing class (envoyproxy#13016) xds: allow empty delta update (envoyproxy#12699) CacheFilter: parses the allowed_vary_headers from the cache config. (envoyproxy#12928) router: extend HTTP CONNECT route matching criteria (envoyproxy#13056) docs: clarify use of Extended CONNECT for h/2 (envoyproxy#13051) build: shellcheck tools/ (envoyproxy#13007) [fuzz] Refactored Health Checker Impl Tests (envoyproxy#13017) Signed-off-by: Lihao Luo <lihao@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message: Shellcheck: tools/
Additional Description:
Risk Level: low
Testing:
Docs Changes:
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue] Partial fix for #7793
[Optional Deprecated:]