xds: allow empty delta update#12699
Merged
htuch merged 2 commits intoenvoyproxy:masterfrom Sep 11, 2020
Merged
Conversation
f13846e to
95cf8c4
Compare
htuch
reviewed
Aug 18, 2020
Signed-off-by: ouyangxu <ouyangxu@bilibili.com>
95cf8c4 to
3223759
Compare
Contributor
Author
|
ping @htuch 😄 |
htuch
suggested changes
Aug 31, 2020
Member
htuch
left a comment
There was a problem hiding this comment.
Looks good; if you really want to future proof this you could also add an integration test, but don't feel super strong on that. One tiny nit.
/wait
Signed-off-by: ouyangxu <ouyangxu@bilibili.com>
|
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
htuch
approved these changes
Sep 11, 2020
Member
|
LGTM, thanks! |
lhluo
pushed a commit
to lhluo/envoy
that referenced
this pull request
Sep 11, 2020
…code * upstream/master: lint: add more linters for using absl:: over std:: (envoyproxy#13043) udpa: filesystem list collection support for inline entries. (envoyproxy#13028) filter: http: jwt: implement matching for HTTP CONNECT (envoyproxy#13064) [fuzz] split http filter logic into a fuzzing class (envoyproxy#13016) xds: allow empty delta update (envoyproxy#12699) CacheFilter: parses the allowed_vary_headers from the cache config. (envoyproxy#12928) router: extend HTTP CONNECT route matching criteria (envoyproxy#13056) docs: clarify use of Extended CONNECT for h/2 (envoyproxy#13051) build: shellcheck tools/ (envoyproxy#13007) [fuzz] Refactored Health Checker Impl Tests (envoyproxy#13017) Signed-off-by: Lihao Luo <lihao@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
when delta xds recv empty repsonce, it should be call onConfigUpdate, instead of do nothing, and stop init process 15s (initial_fetch_timeout)
Additional Description:
a first delta xds repsonce can't call wildcard subscription's onConfigUpdate (ex: empty CDS), and stop init process 15s. It don't like SOTW part:
envoy/source/common/config/watch_map.cc
Lines 104 to 115 in 7f4e35e
Risk Level: Low
Testing: Manual Pass
Docs Changes: None
Release Notes: None