build/test: remove some lightstep deps, split lightstep tests into di…#1248
Merged
htuch merged 5 commits intoenvoyproxy:masterfrom Jul 12, 2017
Merged
build/test: remove some lightstep deps, split lightstep tests into di…#1248htuch merged 5 commits intoenvoyproxy:masterfrom
htuch merged 5 commits intoenvoyproxy:masterfrom
Conversation
…stinct targets. We don't have Lightstep available at Google, so we would like to avoid taking the dependency in tests.
| "type": "lightstep", | ||
| "config": { | ||
| "access_token_file": "{{ test_rundir }}/test/config/integration/lightstep_access_token", | ||
| "collector_cluster": "lightstep_saas" |
Member
There was a problem hiding this comment.
Can we delete the cluster definition also? Same below?
|
|
||
| namespace Envoy { | ||
|
|
||
| using testing::NiceMock; |
Member
There was a problem hiding this comment.
nit: using stuff outside of Envoy namespace.
mattklein123
approved these changes
Jul 12, 2017
Member
mattklein123
left a comment
There was a problem hiding this comment.
Assuming we didn't lose any coverage here of the initial lightstep driver load in the public tests, this looks good to me.
Member
Author
|
BTW, I checked coverage on master and it doesn't look like there's any regression on the lightstep config or implementation. |
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
nezdolik
pushed a commit
to nezdolik/envoy
that referenced
this pull request
May 4, 2024
It is actually needed for libgcc backtracer from time to time. And we've seen libunwind to need it too. Plus we've not heard of any problems with it. So lets just always enable it. This should fix github issue envoyproxy#1248.
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Description** This adds an end-to-end upgrade testing where we are supposed to test two test scenarios: simply rolling upgrade and control plane upgrade while keep making requests and verify no requests are dropped. What we found is that, as reported in #1241, there's a slight gap between Envoy stop receiving requests and extproc termination, hence users might experience requests being dropped during upgrade. The fundamental fix is to set extproc sidecar container in the k8s API sense, but it's only available after k8s v1.33 by default. So, this adds a common workaround to sleep before the context cancelation. The workaround fix is verified to work in the newly added e2e upgrade tests. After this is merged, adding k8s-version detection and enabling sidecar by default automatically as well as backporting the fix to v0.3 would be necessary. After that, we can enable the control-plane upgrade variant of the test case that is currently disabled in this commit. **Related Issues/PRs (if applicable)** Closes #1241 Closes #1060 --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Description** This is a follow up on #1248 and #1255. This switches to use metallb instead of port-forwarding multiple times to avoid the complexity/race as well as to make the situation closer to the real world scenario where type: LoadBalancer Service is utilized to access the gateway rather than directly accessing pod ips via port-forward. --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Description** This is a follow up on #1248. We need to ensure that extproc outlives Envoy process and that can be easily achieved by configuring the extproc container as a sidecar container in the k8s API level. Since that feature is only available in k8s newer than v1.32, this adds a simple logic to check the version to switch the container insertion to ensure the old deployment works as intended. --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Description** This is a follow up on #1248, and enables the skipped test case by using the old commit hash. We will pin it later to the next version which is v0.4.0. Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…stinct targets.
We don't have Lightstep available at Google, so we would like to avoid taking the dependency in
tests.