compdb: use aspects generated header files#12426
Merged
mattklein123 merged 3 commits intoenvoyproxy:masterfrom Aug 3, 2020
Merged
compdb: use aspects generated header files#12426mattklein123 merged 3 commits intoenvoyproxy:masterfrom
mattklein123 merged 3 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
moderation
reviewed
Aug 3, 2020
Comment on lines
+47
to
+48
| # 2020-07-31 | ||
| urls = ["https://github.com/grailbio/bazel-compilation-database/archive/c37b909045eb72d29a47f77cc1e9b519dd5c10b6.tar.gz"], |
Contributor
There was a problem hiding this comment.
Wish I had caught this earlier but this commit is in the latest 0.4.5 release. I'm move back to the release in a subsequent PR.
bazel_compdb = dict(
sha256 = "bcecfd622c4ef272fd4ba42726a52e140b961c4eac23025f18b346c968a8cfb4",
strip_prefix = "bazel-compilation-database-0.4.5",
urls = ["https://github.com/grailbio/bazel-compilation-database/archive/0.4.5.tar.gz"],
use_category = ["build"],
),
chaoqin-li1123
pushed a commit
to chaoqin-li1123/envoy
that referenced
this pull request
Aug 7, 2020
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
chaoqin-li1123
pushed a commit
to chaoqin-li1123/envoy
that referenced
this pull request
Aug 7, 2020
Signed-off-by: Lizan Zhou <lizan@tetrate.io> Signed-off-by: chaoqinli <chaoqinli@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clear tech debts solved by grailbio/bazel-compilation-database#58, this should make compilation database generation much faster than before especially when cache doesn't exist.
Signed-off-by: Lizan Zhou lizan@tetrate.io