This repository was archived by the owner on Mar 17, 2024. It is now read-only.
handle generated headers and virtual_includes via output_group#58
Merged
siddharthab merged 3 commits intograilbio:masterfrom Aug 1, 2020
Merged
handle generated headers and virtual_includes via output_group#58siddharthab merged 3 commits intograilbio:masterfrom
siddharthab merged 3 commits intograilbio:masterfrom
Conversation
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Contributor
Author
|
CI failure looks unrelated |
Collaborator
|
Thanks for the change! I am surprised it was really this simple. CI tests are good. I have to make the macOS tests more robust to XCode version changes. Also, migration tests always fail because of the way bazelisk fetches the list of flags; I have to check if there is a better way to check that. I will take a more detailed look in a bit. |
Contributor
Author
|
Yeah I was surprised too when I was look into this. This make our compilation generation much faster. We used to run bazel build before generation just to make sure headers are generated. |
added 2 commits
July 31, 2020 18:54
9454ba0 to
a159fcf
Compare
siddharthab
pushed a commit
that referenced
this pull request
Aug 1, 2020
Define a output group `header_files` containing all headers needed recursively by the target. This will let Bazel generate header files when necessary (for example, cc_proto_library), and setup virtual_includes directories as well (for example, when using strip_include_prefix and include_prefix attribute). Fixes #29. Co-authored-by: Siddhartha Bagaria <sbagaria@grailbio.com>
Collaborator
|
Sorry, I force pushed a commit fixing the commit message in the original commit. That's why the PR shows two commits. |
Collaborator
|
Thanks @lizan ! |
Contributor
Author
|
No worries, thanks for merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define a output group
header_filescontains all headers needed by the target including generated ones, virtual_includes. This will let Bazel generate header files when necessary (for example,cc_proto_library), and setupvirtual_includesdirectories as well.Fixes #29.
Signed-off-by: Lizan Zhou lizan@tetrate.io