api: Back-port SelfConfigSource.transport_api_version field to v2.#11824
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Jul 1, 2020
Merged
Conversation
Signed-off-by: Mark D. Roth <roth@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
htuch
approved these changes
Jul 1, 2020
Member
htuch
left a comment
There was a problem hiding this comment.
LGTM. Since this is intended to support the migration from v2 to v3, it can override the v2 freeze.
Member
|
/lgtm v2-freeze |
Member
|
The API job failed due to some strange PyYAML issue, rerunning to see if it was some kind of infrastructure flake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mark D. Roth roth@google.com
Commit Message: api: Back-port SelfConfigSource.transport_api_version field to v2.
Additional Description: Back-port #11754 to the v2 API. This will make it easier for users to migrate to v3.
Risk Level: Low
Testing: N/A
Docs Changes: Inline in PR
Release Notes: N/A
As discussed with @htuch.