Skip to content

api: Add transport_api_version to SelfConfigSource.#11754

Merged
htuch merged 1 commit intoenvoyproxy:masterfrom
markdroth:self_config_source_transport_api_version
Jun 25, 2020
Merged

api: Add transport_api_version to SelfConfigSource.#11754
htuch merged 1 commit intoenvoyproxy:masterfrom
markdroth:self_config_source_transport_api_version

Conversation

@markdroth
Copy link
Copy Markdown
Contributor

Signed-off-by: Mark D. Roth roth@google.com

Commit Message: api: Add transport_api_version to SelfConfigSource.
Additional Description: This will allow configuring the version of LRS independently from the version of xDS in the lrs_server field in Cluster messages.
Risk Level: Low
Testing: N/A
Docs Changes: Inline in PR
Release Notes: N/A

Signed-off-by: Mark D. Roth <roth@google.com>
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/envoy/.
CC @envoyproxy/api-watchers: FYI only for changes made to api/envoy/.

🐱

Caused by: #11754 was opened by markdroth.

see: more, trace.

@markdroth
Copy link
Copy Markdown
Contributor Author

As discussed with @htuch.

@htuch htuch merged commit edaad6d into envoyproxy:master Jun 25, 2020
@markdroth markdroth deleted the self_config_source_transport_api_version branch June 26, 2020 19:11
yashwant121 pushed a commit to yashwant121/envoy that referenced this pull request Jul 24, 2020
This will allow configuring the version of LRS independently from the version of xDS in the lrs_server field in Cluster messages.

Risk Level: Low
Testing: N/A
Docs Changes: Inline in PR

Signed-off-by: Mark D. Roth <roth@google.com>
Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants