Skip to content

api: add eds config to csds proto#11662

Merged
htuch merged 3 commits intoenvoyproxy:masterfrom
Rainton:csds-branch
Jun 22, 2020
Merged

api: add eds config to csds proto#11662
htuch merged 3 commits intoenvoyproxy:masterfrom
Rainton:csds-branch

Conversation

@Rainton
Copy link
Copy Markdown
Contributor

@Rainton Rainton commented Jun 19, 2020

Commit Message:
add EDS config to csds proto.

Additional Description:
EDS config has been added to config_dump in #11425 and implemented in #11577 .

Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Yutong Li yutongli@google.com
/cc @fuqianggao @alexburnos

Signed-off-by: Yutong Li <yutongli@google.com>
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/.
CC @envoyproxy/api-watchers: FYI only for changes made to api/.

🐱

Caused by: #11662 was opened by Rainton.

see: more, trace.

@htuch htuch self-assigned this Jun 19, 2020
Signed-off-by: Yutong Li <yutongli@google.com>
htuch
htuch previously approved these changes Jun 19, 2020
Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Signed-off-by: Yutong Li <yutongli@google.com>
@Rainton
Copy link
Copy Markdown
Contributor Author

Rainton commented Jun 19, 2020

@htuch Sorry about my misspelling. Just corrected it to [#not-implemented-hide:]

@fuqianggao
Copy link
Copy Markdown
Contributor

LGTM. Thank you.

@htuch htuch merged commit 1bb927e into envoyproxy:master Jun 22, 2020
songhu pushed a commit to songhu/envoy that referenced this pull request Jun 25, 2020
EDS config has been added to config_dump in envoyproxy#11425 and implemented in envoyproxy#11577 .

Risk Level: Low
Testing: N/A

Signed-off-by: Yutong Li <yutongli@google.com>
yashwant121 pushed a commit to yashwant121/envoy that referenced this pull request Jul 24, 2020
EDS config has been added to config_dump in envoyproxy#11425 and implemented in envoyproxy#11577 .

Risk Level: Low
Testing: N/A

Signed-off-by: Yutong Li <yutongli@google.com>
Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants