Merged
Conversation
Signed-off-by: Yutong Li <yutongli@google.com>
Contributor
Author
|
I will implement this in Envoy later. |
Signed-off-by: Yutong Li <yutongli@google.com>
fuqianggao
reviewed
Jun 3, 2020
|
|
||
| // [#not-implemented-hide:] | ||
| // Envoy's EDS implementation *will* fill this message with all currently known endpoints. Endpoint | ||
| // configuration information can be used to recreate an Envoy configuration by populating all |
Contributor
There was a problem hiding this comment.
Just a thought, since number of endpoints could potentially be very large, do we want to dump out all of them or should we have some upper limit.
Would like to see what the API reviewer thinks.
Member
There was a problem hiding this comment.
For the admin handler, this could be just a query param. Could be worth adding as needed.
htuch
pushed a commit
that referenced
this pull request
Jun 22, 2020
songhu
pushed a commit
to songhu/envoy
that referenced
this pull request
Jun 25, 2020
EDS config has been added to config_dump in envoyproxy#11425 and implemented in envoyproxy#11577 . Risk Level: Low Testing: N/A Signed-off-by: Yutong Li <yutongli@google.com>
yashwant121
pushed a commit
to yashwant121/envoy
that referenced
this pull request
Jul 24, 2020
Add EndpointsConfigDump message to support EDS in config_dump.proto (not implemented in Envoy) Additional Description: Risk Level: Low Testing: N/A Docs Changes: N/A Release Notes: N/A This is the first step to solve envoyproxy#3362 Signed-off-by: Yutong Li <yutongli@google.com> Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
yashwant121
pushed a commit
to yashwant121/envoy
that referenced
this pull request
Jul 24, 2020
EDS config has been added to config_dump in envoyproxy#11425 and implemented in envoyproxy#11577 . Risk Level: Low Testing: N/A Signed-off-by: Yutong Li <yutongli@google.com> Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
add
EndpointsConfigDumpmessage to support EDS in config_dump.proto(not implemented in Envoy)
Additional Description:
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
This is the first step to solve #3362
Signed-off-by: Yutong Li yutongli@google.com
/cc @fuqianggao @alexburnos