Upgrading libevent to latest commit#11137
Merged
htuch merged 2 commits intoenvoyproxy:masterfrom May 14, 2020
Merged
Conversation
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Contributor
Author
|
If you think of any benchmarks that should be run, I'm happy to do so. |
Contributor
|
This looks like legit breakage upstream to the windows platform. We can investigate this early this week, should have an answer at some point today or tomorrow. |
Contributor
|
This is not a regression per se, but a new additional prerequisite. Try adding the following patch to pass on windows... |
Contributor
Author
|
Thanks @wrowe! |
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
lizan
approved these changes
May 13, 2020
This was referenced Jul 1, 2020
buildbreaker
pushed a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Jul 2, 2020
…nvoy (#937) We're reverting the libevent version bump from upstream envoy to avoid the commit which introduced a usage of `pthread_mutexattr_setprotocol`. The libevent change is [here](libevent/libevent@f76456b). The upstream envoy change was primarily targeted for windows. Upstream change for updating libevent: envoyproxy/envoy#11137 Addressing missing symbol: #934 Will need to lower to 21: #936 Signed-off-by: Alan Chiu <achiu@lyft.com> For an explanation of how to fill out the fields, please see the relevant section in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/master/PULL_REQUESTS.md) Description: android: fixate to API 24 and use old libevent version for upstream envoy Risk Level: low Testing: ci Docs Changes: n/a Release Notes: n/a [Optional Fixes #Issue] [Optional Deprecated:]
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
…nvoy (#937) We're reverting the libevent version bump from upstream envoy to avoid the commit which introduced a usage of `pthread_mutexattr_setprotocol`. The libevent change is [here](libevent/libevent@f76456b). The upstream envoy change was primarily targeted for windows. Upstream change for updating libevent: #11137 Addressing missing symbol: envoyproxy/envoy-mobile#934 Will need to lower to 21: envoyproxy/envoy-mobile#936 Signed-off-by: Alan Chiu <achiu@lyft.com> For an explanation of how to fill out the fields, please see the relevant section in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/master/PULL_REQUESTS.md) Description: android: fixate to API 24 and use old libevent version for upstream envoy Risk Level: low Testing: ci Docs Changes: n/a Release Notes: n/a [Optional Fixes #Issue] [Optional Deprecated:] Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
…nvoy (#937) We're reverting the libevent version bump from upstream envoy to avoid the commit which introduced a usage of `pthread_mutexattr_setprotocol`. The libevent change is [here](libevent/libevent@f76456b). The upstream envoy change was primarily targeted for windows. Upstream change for updating libevent: #11137 Addressing missing symbol: envoyproxy/envoy-mobile#934 Will need to lower to 21: envoyproxy/envoy-mobile#936 Signed-off-by: Alan Chiu <achiu@lyft.com> For an explanation of how to fill out the fields, please see the relevant section in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/master/PULL_REQUESTS.md) Description: android: fixate to API 24 and use old libevent version for upstream envoy Risk Level: low Testing: ci Docs Changes: n/a Release Notes: n/a [Optional Fixes #Issue] [Optional Deprecated:] Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrading libevent to solve phantom event bug - an event that was triggered after closing connections.
Risk Level: Low-medium - basic functionality hasn’t changed, but there might be a few corner cases and performance that will be affected.
Testing: None added
Signed-off-by: Adi Suissa-Peleg adip@google.com