android: fixate to API 24 and use old libevent version for upstream envoy#937
Merged
buildbreaker merged 5 commits intomasterfrom Jul 2, 2020
Merged
android: fixate to API 24 and use old libevent version for upstream envoy#937buildbreaker merged 5 commits intomasterfrom
buildbreaker merged 5 commits intomasterfrom
Conversation
Signed-off-by: Alan Chiu <achiu@lyft.com>
Signed-off-by: Keith Smiley <keithbsmiley@gmail.com> Signed-off-by: Alan Chiu <achiu@lyft.com>
keith
previously approved these changes
Jul 1, 2020
Signed-off-by: Alan Chiu <achiu@lyft.com>
168cee8 to
9d3446a
Compare
keith
previously approved these changes
Jul 2, 2020
keith
approved these changes
Jul 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're reverting the libevent version bump from upstream envoy to avoid the commit which introduced a usage of
pthread_mutexattr_setprotocol. The libevent change is here. The upstream envoy change was primarily targeted for windows.Upstream change for updating libevent: envoyproxy/envoy#11137
Addressing missing symbol: #934
Will need to lower to 21: #936
Signed-off-by: Alan Chiu achiu@lyft.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: android: fixate to API 24 and use old libevent version for upstream envoy
Risk Level: low
Testing: ci
Docs Changes: n/a
Release Notes: n/a
[Optional Fixes #Issue]
[Optional Deprecated:]