[config] Add basic config validators for path rewrite, host rewrite and redirect actions#10367
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Mar 15, 2020
Merged
Conversation
…ct actions that reject \0, \r and \n characters. Signed-off-by: Antonio Vicente <avd@google.com>
Member
|
/azp run envoy-windows |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Contributor
Contributor
Author
|
First CI attempt failed due to gitdb package being too old. Now the mac CI failed while installing dependencies. I'll kick it again sometime later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Reject path rewrite, host rewrite and redirect config fields that contain \0, \r or \n characters. This provides some basic protection against config errors that could result in problems due to the proxy, upstream and downstream disagreeing about the contents of headers.
Risk Level: medium
Testing: Added config tests that trigger on the new validations
Docs Changes: n/a
Release Notes: TBD
Fixes #10332