Description:
These are various places where we need to follow up to complete removal of C style strings in the header map.
HeaderString::find(const char* str) can probably be eliminated entirely by converting call sites to use getStringView().find().
StringUtil::atoull currently requires creation of some temporary std::string objects because it expects C strings, and also returns a C style string. Most call sites ignore the return value, so they can be converted to use absl::SimpleAtoi or a new StringUtil function that takes and returns string views.
UuidUtils::uuidModBy() should be migrated to take absl::string_view
Span::setOperation() should be migrated to take absl::string_view
Context:
#6494
#6564
Action item for CVE-2019-9900
Description:
These are various places where we need to follow up to complete removal of C style strings in the header map.
HeaderString::find(const char* str)can probably be eliminated entirely by converting call sites to usegetStringView().find().StringUtil::atoullcurrently requires creation of some temporarystd::stringobjects because it expects C strings, and also returns a C style string. Most call sites ignore the return value, so they can be converted to useabsl::SimpleAtoior a newStringUtilfunction that takes and returns string views.UuidUtils::uuidModBy()should be migrated to takeabsl::string_viewSpan::setOperation()should be migrated to takeabsl::string_viewContext:
#6494
#6564
Action item for CVE-2019-9900