Remove ASYNCIFY_LAZY_LOAD_CODE#25236
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Sep 9, 2025
Merged
Conversation
sbc100
commented
Sep 9, 2025
| # a lot of code | ||
| # TODO: support other asyncify stuff, imports that don't always unwind? | ||
| # TODO: source maps etc. | ||
| args = ['--mod-asyncify-always-and-only-unwind'] |
Collaborator
Author
There was a problem hiding this comment.
@kripken, can we remove any of this stuff from binaryen once this change lands?
Member
There was a problem hiding this comment.
Yes, the --mod-asyncify* passes are just for this. I'm not aware of any other use.
This was marked a deprecated in emscripten-core#24383 and nobody has chimed in that they are using it. Fixes: emscripten-core#16828
9f2f2e2 to
2f92755
Compare
kripken
approved these changes
Sep 9, 2025
sbc100
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Sep 9, 2025
sbc100
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Sep 9, 2025
sbc100
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Sep 10, 2025
sbc100
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Sep 10, 2025
inolen
pushed a commit
to inolen/emscripten
that referenced
this pull request
Feb 13, 2026
This was marked a deprecated in emscripten-core#24383 and nobody has chimed in that they are using it. Fixes: emscripten-core#16828
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was marked a deprecated in #24383 and nobody has chimed in that they are using it.
Fixes: #16828