Skip to content

Mark ASYNCIFY_LAZY_LOAD_CODE as deprecated#24383

Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom
sbc100:deprecate_lazy_load_code
May 21, 2025
Merged

Mark ASYNCIFY_LAZY_LOAD_CODE as deprecated#24383
sbc100 merged 1 commit intoemscripten-core:mainfrom
sbc100:deprecate_lazy_load_code

Conversation

@sbc100
Copy link
Copy Markdown
Collaborator

@sbc100 sbc100 commented May 20, 2025

This setting was added as an experiment a long time ago and as far we know has no active users.

@sbc100 sbc100 requested a review from kripken May 20, 2025 21:59
@sbc100 sbc100 force-pushed the deprecate_lazy_load_code branch from 6a8cb15 to 25180c2 Compare May 20, 2025 22:00
@sbc100 sbc100 changed the title Mark EMSCRIPTEN_LAZY_LOAD_CODE as deprecated Mark ASYNCIFY_LAZY_LOAD_CODE as deprecated May 20, 2025
@sbc100 sbc100 requested review from brendandahl and dschuff May 20, 2025 23:50
4.0.10 (in development)
----------------------
- The `-sASYNCIFY_LAZY_LOAD_CODE` setting was deprecated. This setting was
added as an experiment a long time ago and as far we know has no active users.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
added as an experiment a long time ago and as far we know has no active users.
added as an experiment a long time ago and as far we know has no active users.
Also, its approach cannot work with JSPI (the future of ASYNCIFY).

This setting was added as an experiment a long time ago and as far we
know has no active users.
@sbc100 sbc100 force-pushed the deprecate_lazy_load_code branch from 25180c2 to 9e11bba Compare May 21, 2025 01:06
@sbc100 sbc100 merged commit fc311f3 into emscripten-core:main May 21, 2025
0 of 11 checks passed
@sbc100 sbc100 deleted the deprecate_lazy_load_code branch May 21, 2025 01:06
Lukasdoe pushed a commit to Lukasdoe/emscripten that referenced this pull request Jun 19, 2025
This setting was added as an experiment a long time ago and as far we
know has no active users.
sbc100 added a commit to sbc100/emscripten that referenced this pull request Sep 9, 2025
This was marked a deprecated in emscripten-core#24383 and nobody has chimed in that
they are using it.

Fixes: emscripten-core#16828
sbc100 added a commit to sbc100/emscripten that referenced this pull request Sep 9, 2025
This was marked a deprecated in emscripten-core#24383 and nobody has chimed in that
they are using it.

Fixes: emscripten-core#16828
sbc100 added a commit that referenced this pull request Sep 9, 2025
This was marked a deprecated in #24383 and nobody has chimed in that
they are using it.

Fixes: #16828
inolen pushed a commit to inolen/emscripten that referenced this pull request Feb 13, 2026
This was marked a deprecated in emscripten-core#24383 and nobody has chimed in that
they are using it.

Fixes: emscripten-core#16828
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants