-
Notifications
You must be signed in to change notification settings - Fork 529
Improve PHPCS config, start some cleanup #1928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ecd9626 to
99edcc0
Compare
|
@TrystanLea This can land. Just be aware in future, patches really shouldn't be merged unless the tests pass - otherwise there's no point in having them :) We should slowly go through these rules, and remove the |
|
Thanks @reedy I've added a few inline comments. Are you just running this command but on a small number of files for the above changes? |
|
I'm just running 'composer fix' which runs on everything, excluding vendor and Lib. |
|
The indenting issues is probably from files not having consistent (tabs or spaces) indenting, not to consistent levels. And without a specific config setting that, it may just be getting confused as part of doing other changes... Seeing as it's not doing weird things on most of the files in the repo, we can probably just fix that by hand one time and should be good going forward. Like I say, if we can decide whether we actually want tabs or spaces, getting that fixed should be easier. |
More pinging of emoncms#1336 Follows up emoncms#1585
|
Before we go any further with this, lets get json_i18b merged in first, seeing lots of merge conflicts |
More pinging of #1336
Follows up #1585