This is the bare minimum to get it running. It'll no doubt fail, so we put rule amendments ontop :)

Filed #1586 as travis isn't running here now...

But it is running in my fork

See https://travis-ci.org/github/reedy/emoncms/jobs/679410625 for example failures. It gave up because of there being so many, but we can narrow it; turning off rules, or scanning for certain files etc

Ok, https://travis-ci.org/github/reedy/emoncms/jobs/679413070 is more representative

Great, maybe we should fix some of these before merging this in :)

Great, maybe we should fix some of these before merging this in :)

I would probably concur. And/or as a seperate commit in the same tree

I imagine we don't want to run it on the Lib directory either... But there's code in there (like with JS) that seems to be non 3rd party...

Also, if Travis was running, we want things fixed first (or rules disabled) rather than it failing patches for errors already there

Is this the right time to move to "php-parallel-lint/php-parallel-lint": "1.2.*" as the currently used one is marked as abandoned?

Is this the right time to move to "php-parallel-lint/php-parallel-lint": "1.2.*" as the currently used one is marked as abandoned?

It's completely unrelated, so should be a seperate patch IMHO :)

Noting, while the warning is (intentionally) scary, I don't think there's been any major bugs fixed, so not massively urgent.

In other projects we've been waiting for them to fix up the sub libraries to update namings, tag releases and bring it all together before updating - For example php-parallel-lint/PHP-Console-Highlighter#1 and php-parallel-lint/PHP-Console-Color#1

Though, this probably isn't a problem here... I'll make a patch in a bit :)

Though, this probably isn't a problem here... I'll make a patch in a bit :)

Done for all repos

Sorry for dropping this, what should I do to take this forwards?

Mostly just needs a rebase and the package updating to 3.13.2...

Mostly just needs a rebase and the package updating to 3.13.2...

Oh, and deciding what to do about the test failures. Usual answer is "fix them" or add them to exclusions...

Not sure why I didn't add a .phpcs.xml, but 5 years have passed ;)

Yeah, needs a config file to at least suppress things we're not going to fix (yet)...

Thanks @reedy !

Why have you merged it when the tests are failing? 😅

Followup coming