Skip to content

Ensuring consistent code style #1336

@reedy

Description

@reedy

I don't mind how code is styled (things like tabs vs spaces - #131), but it's nice if it's standardised, and also enforced by CI to prevent regressions and keep things from regressing

Is anyone against using PHPCS on this repo, and gradually enabling rules to define a coding standard, to make things consistent?

Something that does slightly concern me is the lack of braces being used on ifs... And hopefully we're all aware of the problems this can cause elsewhere...

It'll be a bit disruptive to update the various files (that aren't 3rd party) to consistently use braces, but I think the benefit in the long run is worth it. Most rebasing should be relatively trivial

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions