[CLEANUP beta] Drop export of built-ins, remove legacy components#19806
Merged
rwjblue merged 1 commit intoemberjs:masterfrom Nov 10, 2021
Merged
[CLEANUP beta] Drop export of built-ins, remove legacy components#19806rwjblue merged 1 commit intoemberjs:masterfrom
rwjblue merged 1 commit intoemberjs:masterfrom
Conversation
7544d6b to
6c60515
Compare
nlfurniss
reviewed
Oct 27, 2021
packages/@ember/-internals/runtime/lib/mixins/target_action_support.js
Outdated
Show resolved
Hide resolved
561227a to
7639bc5
Compare
mixonic
commented
Nov 3, 2021
|
|
||
| class LinkTo extends InternalComponent implements DeprecatingInternalComponent { | ||
| /** | ||
| The `LinkTo` component renders a link to the supplied `routeName` passing an optionally |
Member
Author
There was a problem hiding this comment.
Docs moved here from the deleted -link-to.ts
ece8f00 to
3d7d294
Compare
5b38e47 to
e348f9b
Compare
Member
Author
|
@chancancode this is ready for a close read if you can spare the time. I'm going to work next on:
I'll leave a |
mixonic
commented
Nov 5, 2021
b6923c0 to
f038bee
Compare
f038bee to
760c91d
Compare
* Remove the export of `@ember/component/checkbox` * Remove the export of `@ember/component/text-field` * Remove the export of `@ember/component/text-area` * Remove the export of `@ember/component/link-component` * Remove the assignment of `Ember.Checkbox` * Remove the assignment of `Ember.TextField` * Remove the assignment of `Ember.TextArea` * Remove the assignment of `Ember.LinkComponent` * Remove the assignment of `Ember.TextSupport` * Remove the assignment of `Ember.TargetActionSupport` * Hard-code `EMBER_MODERNIZED_BUILT_IN_COMPONENTS` to `true` path in most places. The remaining are a few spots where there are deprecations targeting *5.0*. * Hard-code the built-in components (`<Textarea>`, `<Input>`, `<LinkTo>`) for the modernized path * Remove the `query-params` helper (it is only needed by the legacy `LinkComponent` and was deprecated). * Review emberjs#19669 and ensure all `disabledWhen` is removed. * Review emberjs#19662 and ensure all `@tagName` support is removed * Review all `ember.built-in-components.*` deprecations and ensure their functionality is removed. * Remove code supporting `ember-glimmer.link-to.positional-arguments`, basically https://github.com/emberjs/ember.js/blob/master/packages/ember-template-compiler/lib/plugins/transform-link-to.ts
760c91d to
5d24ae7
Compare
mixonic
added a commit
to emberjs/ember-legacy-built-in-components
that referenced
this pull request
Nov 9, 2021
Ember asset built with `node bin/build-for-publishing.js` on the PR emberjs/ember.js#19806
rwjblue
approved these changes
Nov 10, 2021
Contributor
|
Nice lookin' PR. |
This was referenced Nov 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #19617
@ember/component/checkbox@ember/component/text-field@ember/component/text-area@ember/component/link-componentEmber.CheckboxEmber.TextFieldEmber.TextAreaEmber.LinkComponentEmber.TextSupportEmber.TargetActionSupportRemove the assignment ofI broughtEmber._Input(what is this?)_Inputback as it is under test. I'm not familiar with its usage.EMBER_MODERNIZED_BUILT_IN_COMPONENTStotruepath in most places. The remaining are a few spots where there are deprecations targeting 5.0.<Textarea>,<Input>,<LinkTo>) for the modernized pathquery-paramshelper (it is only needed by the legacyLinkComponentand was deprecated).disabledWhenis removed.@tagNamesupport is removedember.built-in-components.*deprecations and ensure their functionality is removed.ember-glimmer.link-to.positional-arguments, basically https://github.com/emberjs/ember.js/blob/master/packages/ember-template-compiler/lib/plugins/transform-link-to.ts