[DOC beta] Deprecation link for Ember.Component.reopen#19744
Merged
locks merged 1 commit intoemberjs:masterfrom Oct 1, 2021
Merged
[DOC beta] Deprecation link for Ember.Component.reopen#19744locks merged 1 commit intoemberjs:masterfrom
locks merged 1 commit intoemberjs:masterfrom
Conversation
jenweber
approved these changes
Sep 8, 2021
Contributor
jenweber
left a comment
There was a problem hiding this comment.
The deprecation guide has been merged, so this can move forward.
@Glarregle please mark your commit with [DOC beta] at the beginning of the commit message. This will help us make sure it gets in for the next release.
Contributor
Author
|
Thanks @jenweber! Ready! |
Member
|
This needs to be rolled back. This deprecation was targeting 4.0, and we want to remove the functionality in 4.0. Followup from @chancancode is:
|
This was referenced Oct 29, 2021
Contributor
|
@mixonic PR to fix the versions #19823 Sorry for the confusion @Glarregle, we gave you the wrong instructions about version numbers. Thanks again for your help with fixing missing info. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should wait for ember-learn/deprecation-app#948