Use strictEqual QUnit assertion instead of equal in blueprint tests#9671
Merged
rwjblue merged 1 commit intoember-cli:betafrom Oct 20, 2021
Merged
Use strictEqual QUnit assertion instead of equal in blueprint tests#9671rwjblue merged 1 commit intoember-cli:betafrom
strictEqual QUnit assertion instead of equal in blueprint tests#9671rwjblue merged 1 commit intoember-cli:betafrom
Conversation
strictEqual assertion instead of equal in blueprint testsstrictEqual QUnit assertion instead of equal in blueprint tests
Member
|
We probably need to review the blueprints in ember-source and ember-data to make sure they don't emit tests with |
This was referenced Oct 20, 2021
Member
Author
|
Started working on the PRs for ember-source and ember-data: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no-assert-equal is now a recommended rule in eslint-plugin-qunit v7 (#9667).
In JavaScript, we should generally use strict equality checks.
https://api.qunitjs.com/assert/strictEqual/
Targetted to
betabranch so it can go in alongside the eslint-plugin-qunit v7 upgrade.