Switch from QUnit assert.equal() to assert.strictEqual()#19795
Closed
bmish wants to merge 1 commit intoemberjs:masterfrom
Closed
Switch from QUnit assert.equal() to assert.strictEqual()#19795bmish wants to merge 1 commit intoemberjs:masterfrom
assert.equal() to assert.strictEqual()#19795bmish wants to merge 1 commit intoemberjs:masterfrom
Conversation
This was referenced Oct 20, 2021
bde62e3 to
8b0725f
Compare
Contributor
Author
|
Can someone approve the tests to run? |
Member
|
Done @bmish! |
This was referenced Nov 4, 2021
8b0725f to
0654dd0
Compare
Contributor
Author
|
Looks like there are 104 test failures that will mostly require changing between |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no-assert-equal is now a recommended rule in eslint-plugin-qunit v7. In JavaScript, we should generally use strict equality checks like assert.strictEqual.
This PR updates all references in the codebase including internal tests and blueprints used for code generation.
Related to how we are upgrading ember-cli to use eslint-plugin-qunit v7:
strictEqualQUnit assertion instead ofequalin blueprint tests ember-cli/ember-cli#9671assert.equal()toassert.strictEqual()warp-drive-data/warp-drive#7726