Maybe we should strip trailing whitespace in template compilation?

@lukemelia That could break cases where a component's white-space is pre. If I put newlines in the template, keep them, but we should not have the editor append one just to make Unix happy.

@jclem Not to impose (I know there's a good chance you're no longer in the ecosystem) but I have been curious whether you or anyone else have been able to reproduce this text-nodes issue with modern versions of Ember.

One of my colleagues has been frustrated by this setting* and has been insistent that he can't reproduce the original issue with our current version of Ember (i.e., if there's an \n at the end of a template it does not create an extra text node. But it does add such a node if it he adds multiple \ns).

*Even if we disable the EditorConfig rule locally, it's still enforced by TemplateLint + Prettier in compliance with the blueprint default, as was noted in prettier/prettier#6243.

do you think it's worth proposing no empty newline?

or a setting on <template> to remove unneeded invisibles? (such as via https://github.com/mainmatter/ember-hbs-minifier)

using <template> in general gets you around the problem of extra new lines -- but does still have you end up with extra text nodes due to the indentation.

I've been using mainmatter's minifier on my projects, and I'm very happy with it -- I think we should built it in to @glimmer/syntax

@NullVoxPopuli Thanks for the insight. We may be a ways away from fully getting on the <template> bandwagon (we're just now upgrading off 3.28!) but I'd forgotten about that and agree it should ultimately obviate this as a concern. And I'm sure those tools will be useful when we get there.

ember-hbs-minifier supports 3.20+, so that could perhaps work for your existing stuff today?

@NullVoxPopuli On reread, either I'm not quite grokking your solution or I think you've misunderstood our issue.

There has been – since this 2015 PR – a rule that already causes Prettier to complain if there's a newline at the end of a .hbs (which is contrary to how Prettier handles every other file). We think that rule is based on an outdated concern about text nodes (we can't reproduce the issue @jclem originally complained about when he submitted this PR).

I see how a minifier would help with cleaning up empty text nodes... which would help if we were seeing these end-of-template text nodes, but we're not, even if we disable Prettier and add one closing \n (if there's more than one, that's a different story, but that's not what we're concerned about).

Ultimately though, moving to the <template> tag means everything will go into the .gjs files and at that point this special Prettier handling for .hbs will no longer apply. Which is what I thought you were pointing to as the solution.

(For context: we'd previously disabled Prettier from the app blueprint, we recently started looking at applying it and were surprised it was trimming ending newlines only for .hbs, and enforcing them everywhere else.)

I'm no longer in the Ember ecosystem, so I'm sorry that I can't help out here, any longer! I hope all is well in Ember-world, though 😄