fix(glimmer): Add newline at the end of files#6243
fix(glimmer): Add newline at the end of files#6243dcyriller wants to merge 5 commits intoprettier:masterfrom
Conversation
|
Just to be clear: why this change? Because Prettier formats every other language this way. |
|
@dcyriller this goes against https://github.com/ember-cli/ember-new-output/blob/master/.editorconfig#L17 The reason for not having a newline at the end is that it will create an extra DOM text node which in most cases would be unnecessary. |
|
I've hoped for a moment that https://github.com/josephfrazier/editorconfig-to-prettier would have supported the editorconfig option: An alternative would be to submit an RFC in ember community to actually add a newline at the end of hbs files. We could strip trailing whitespace in template compilation as suggested here: ember-cli/ember-cli#3440. |
This PR ensures a trailing newline is added in hbs files.
CHANGELOG.unreleased.mdfile following the template.✨Try the playground for this PR✨