Skip to content

Fix: Nested Carousel #2 test [ED-23145]#34908

Merged
max-zu merged 2 commits intomainfrom
ED-23145
Feb 27, 2026
Merged

Fix: Nested Carousel #2 test [ED-23145]#34908
max-zu merged 2 commits intomainfrom
ED-23145

Conversation

@max-zu
Copy link
Contributor

@max-zu max-zu commented Feb 27, 2026

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Summary

This PR can be summarized in the following changelog entry:

Description

An explanation of what is done in this PR

Test instructions

This PR can be tested by following these steps:

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended
  • Docs have been added / updated (for bug fixes / features)

Fixes #

✨ PR Description

Purpose: Fix event propagation issue in nested carousel component by removing stopPropagation call from container click handler.

Main changes:

  • Removed event parameter and stopPropagation() call from handleAddContainerClick method to allow proper event bubbling
  • Simplified click handler implementation to only trigger preset rendering without blocking parent event handlers

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how

@github-actions
Copy link
Contributor

Review Summary

🚨 Cannot approve - Critical issues must be addressed

Critical Issues (3)

  1. 🚨 PR Template Not Filled: The PR description is empty. Template completion is required per guidelines.

    • Missing: Summary, description, test instructions, PR type checkbox
  2. 🚨 Unexplained Behavioral Change: Removing event.stopPropagation() changes how events propagate to parent handlers (see inline comment)

    • Need explanation: What was the bug? Why is event bubbling now desired?
  3. 🧪 No Test Coverage for Fix: PR title mentions "Fix Nested Carousel strings improvments #2 test" but no test files were modified

    • Test exists: tests/playwright/sanity/modules/nested-tabs/nested-tabs-3.test.ts line 116-152
    • Question: Was the test itself flaky, or was there actual broken functionality?

Required Actions

  1. Fill out the PR template completely
  2. Explain the behavioral change and why it's correct
  3. Verify the test passes and document how this was tested

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. See inline comments for critical issues.

@github-actions github-actions bot added the auto-reviewed PR has been automatically reviewed by CI label Feb 27, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2026

Elementor Build

Last updated at: 20260227.0904
Version: 4.0.0-20260227.0904

✅ Elementor build is ready for download.

You can download the latest build from the link below:

🔗 elementor-4.0.0-20260227.0904.zip

The build is available for 3 days.

@max-zu max-zu changed the title Fix Nested Carousel #2 test [ED-23145] Fix: Nested Carousel #2 test [ED-23145] Feb 27, 2026
@max-zu max-zu added the cp_3.35 label Feb 27, 2026
@max-zu max-zu merged commit bffc570 into main Feb 27, 2026
84 of 86 checks passed
@max-zu max-zu deleted the ED-23145 branch February 27, 2026 09:33
github-actions bot pushed a commit that referenced this pull request Feb 27, 2026
## PR Checklist
<!-- 
Please check if your PR fulfills the following requirements:
**Filling out the template is required.** Any pull request that does not
include enough information to be reviewed in a timely manner may be
closed at the maintainers' discretion.
 -->
- [ ] The commit message follows our guidelines:
https://github.com/elementor/elementor/blob/master/.github/CONTRIBUTING.md


## PR Type
What kind of change does this PR introduce?
<!-- Please check the one that applies to this PR using "x" with no
spaces eg: [x]. -->
- [ ] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## Summary

This PR can be summarized in the following changelog entry:

*

## Description
An explanation of what is done in this PR

*

## Test instructions
This PR can be tested by following these steps:

*

## Quality assurance

- [ ] I have tested this code to the best of my abilities
- [ ] I have added unittests to verify the code works as intended
- [ ] Docs have been added / updated (for bug fixes / features)

Fixes #

<!--start_gitstream_placeholder-->
### ✨ PR Description
Purpose: Fix event propagation issue in nested carousel component by
removing stopPropagation call from container click handler.

Main changes:
- Removed event parameter and stopPropagation() call from
handleAddContainerClick method to allow proper event bubbling
- Simplified click handler implementation to only trigger preset
rendering without blocking parent event handlers

_Generated by LinearB AI and added by gitStream._
<sub>AI-generated content may contain inaccuracies. Please verify before
using.
💡 **Tip:** You can customize your AI Description using **Guidelines**
[Learn
how](https://docs.gitstream.cm/automation-actions/#describe-changes)</sub>
<!--end_gitstream_placeholder-->

Co-authored-by: ElementorBot <48412871+elementorbot@users.noreply.github.com>
max-zu added a commit that referenced this pull request Feb 27, 2026
Automatic cherry-pick of
[#34908](#34908) to `3.35`
branch.

      **Source:** elementor/elementor
      **Original Author:** @max-zu

---------

Co-authored-by: Maksim Zubov <zubovmaksim@gmail.com>
Co-authored-by: ElementorBot <48412871+elementorbot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 min review auto-reviewed PR has been automatically reviewed by CI cp_3.35

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants