Skip to content

strings improvments#2

Merged
KingYes merged 3 commits intoelementor:masterfrom
ramiy:master
May 30, 2016
Merged

strings improvments#2
KingYes merged 3 commits intoelementor:masterfrom
ramiy:master

Conversation

@ramiy
Copy link
Contributor

@ramiy ramiy commented May 30, 2016

  • Merge similar strings: link to => Link to
  • Merge similar strings: Icon Postion => Icon Position (It's a typo, missing i)

@KingYes KingYes merged commit b978246 into elementor:master May 30, 2016
KingYes added a commit that referenced this pull request Jun 21, 2016
Gallery and Carousel Widgets #2
joshmarom referenced this pull request in joshmarom/elementor Dec 25, 2016
KingYes pushed a commit that referenced this pull request Mar 13, 2017
@norewp norewp mentioned this pull request Nov 7, 2017
@EdKnep EdKnep mentioned this pull request Mar 28, 2018
@odedta odedta mentioned this pull request May 23, 2018
@unclerom unclerom mentioned this pull request Jun 18, 2018
5 tasks
ronros-elementor added a commit to ronros-elementor/elementor that referenced this pull request Jul 29, 2025
ronros-elementor added a commit to ronros-elementor/elementor that referenced this pull request Nov 23, 2025
max-zu added a commit that referenced this pull request Feb 27, 2026
max-zu added a commit that referenced this pull request Feb 27, 2026
## PR Checklist
<!-- 
Please check if your PR fulfills the following requirements:
**Filling out the template is required.** Any pull request that does not
include enough information to be reviewed in a timely manner may be
closed at the maintainers' discretion.
 -->
- [ ] The commit message follows our guidelines:
https://github.com/elementor/elementor/blob/master/.github/CONTRIBUTING.md


## PR Type
What kind of change does this PR introduce?
<!-- Please check the one that applies to this PR using "x" with no
spaces eg: [x]. -->
- [ ] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## Summary

This PR can be summarized in the following changelog entry:

*

## Description
An explanation of what is done in this PR

*

## Test instructions
This PR can be tested by following these steps:

*

## Quality assurance

- [ ] I have tested this code to the best of my abilities
- [ ] I have added unittests to verify the code works as intended
- [ ] Docs have been added / updated (for bug fixes / features)

Fixes #

<!--start_gitstream_placeholder-->
### ✨ PR Description
Purpose: Fix event propagation issue in nested carousel component by
removing stopPropagation call from container click handler.

Main changes:
- Removed event parameter and stopPropagation() call from
handleAddContainerClick method to allow proper event bubbling
- Simplified click handler implementation to only trigger preset
rendering without blocking parent event handlers

_Generated by LinearB AI and added by gitStream._
<sub>AI-generated content may contain inaccuracies. Please verify before
using.
💡 **Tip:** You can customize your AI Description using **Guidelines**
[Learn
how](https://docs.gitstream.cm/automation-actions/#describe-changes)</sub>
<!--end_gitstream_placeholder-->

Co-authored-by: ElementorBot <48412871+elementorbot@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Feb 27, 2026
## PR Checklist
<!-- 
Please check if your PR fulfills the following requirements:
**Filling out the template is required.** Any pull request that does not
include enough information to be reviewed in a timely manner may be
closed at the maintainers' discretion.
 -->
- [ ] The commit message follows our guidelines:
https://github.com/elementor/elementor/blob/master/.github/CONTRIBUTING.md


## PR Type
What kind of change does this PR introduce?
<!-- Please check the one that applies to this PR using "x" with no
spaces eg: [x]. -->
- [ ] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## Summary

This PR can be summarized in the following changelog entry:

*

## Description
An explanation of what is done in this PR

*

## Test instructions
This PR can be tested by following these steps:

*

## Quality assurance

- [ ] I have tested this code to the best of my abilities
- [ ] I have added unittests to verify the code works as intended
- [ ] Docs have been added / updated (for bug fixes / features)

Fixes #

<!--start_gitstream_placeholder-->
### ✨ PR Description
Purpose: Fix event propagation issue in nested carousel component by
removing stopPropagation call from container click handler.

Main changes:
- Removed event parameter and stopPropagation() call from
handleAddContainerClick method to allow proper event bubbling
- Simplified click handler implementation to only trigger preset
rendering without blocking parent event handlers

_Generated by LinearB AI and added by gitStream._
<sub>AI-generated content may contain inaccuracies. Please verify before
using.
💡 **Tip:** You can customize your AI Description using **Guidelines**
[Learn
how](https://docs.gitstream.cm/automation-actions/#describe-changes)</sub>
<!--end_gitstream_placeholder-->

Co-authored-by: ElementorBot <48412871+elementorbot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants