fix: wait for user selection on delegated lists in desktopCapturer#51674
Merged
Conversation
Contributor
Author
|
This should be backported to 42-x-y and 43-x-y. |
Delegated source lists signal user selection using `OnDelegatedSourceListSelection`, not `OnSourceAdded`. `BaseCapturerPipeWire` adds a placeholder source to preserve the interface shape, but it doesn't mean anything. Ignore `OnSourceAdded` and don't timeout after 3 seconds in case of delegated lists. Assisted-By: Claude Opus 4.7, Claude Code
228df52 to
94d7a21
Compare
ckerr
approved these changes
May 21, 2026
jkleinsc
approved these changes
May 27, 2026
|
Release Notes Persisted
|
Contributor
|
I have automatically backported this PR to "43-x-y", please check out #51783 |
Contributor
|
I have automatically backported this PR to "42-x-y", please check out #51784 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Delegated source lists signal user selection using
OnDelegatedSourceListSelection, notOnSourceAdded.BaseCapturerPipeWireadds a placeholder source to preserve the interface shape, but it doesn't mean anything. IgnoreOnSourceAddedand don't timeout after 3 seconds in case of delegated lists.Fixes #51673
Checklist
npm testpassesRelease Notes
Notes: Fixed desktopCapturer thumbnail generation and premature portal timeout on Linux with Wayland.