fix: wait for user selection on delegated lists in desktopCapturer#51784
Draft
trop[bot] wants to merge 1 commit into
Draft
Conversation
Delegated source lists signal user selection using `OnDelegatedSourceListSelection`, not `OnSourceAdded`. `BaseCapturerPipeWire` adds a placeholder source to preserve the interface shape, but it doesn't mean anything. Ignore `OnSourceAdded` and don't timeout after 3 seconds in case of delegated lists. Assisted-By: Claude Opus 4.7, Claude Code Co-authored-by: Athul Iddya <athul@iddya.com>
5 tasks
ckerr
previously approved these changes
May 27, 2026
Member
|
Converting to draft until I and/or @nikwen can TAL. This trop went green in 43-x-y but is red in 42-x-y. It is a backport of PR #51674, which aims to fix bug #51673, which was caused by PR #50960 (which was backported to 42-x-y) + PR #51128 (which was not). So at first read, I think the Right Thing is to backport 51128 to 42-x-y and then rebase this PR right afterwards, but this needs confirmation. CC stakeholder @nikwen |
Member
|
Thanks for the mention! I'm not a stakeholder on this backport. I needed #51128 only to unblock another PR, which has since been merged. :) |
Contributor
|
@ckerr Both of the dependent PRs were backported to 42-x-y in #51506. I see that the tests failed due to a test dependency or ordering issue, not anything related to this PR: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #51674
See that PR for details.
Notes: Fixed desktopCapturer thumbnail generation and premature portal timeout on Linux with Wayland.