Skip to content

fix: wait for user selection on delegated lists in desktopCapturer#51783

Merged
ckerr merged 1 commit into
43-x-yfrom
trop/43-x-y-bp-fix-wait-for-user-selection-on-delegated-lists-in-desktopcapturer-1779901484202
May 28, 2026
Merged

fix: wait for user selection on delegated lists in desktopCapturer#51783
ckerr merged 1 commit into
43-x-yfrom
trop/43-x-y-bp-fix-wait-for-user-selection-on-delegated-lists-in-desktopcapturer-1779901484202

Conversation

@trop

@trop trop Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor

Backport of #51674

See that PR for details.

Notes: Fixed desktopCapturer thumbnail generation and premature portal timeout on Linux with Wayland.

Delegated source lists signal user selection using
`OnDelegatedSourceListSelection`, not `OnSourceAdded`. `BaseCapturerPipeWire`
adds a placeholder source to preserve the interface shape, but it doesn't
mean anything. Ignore `OnSourceAdded` and don't timeout after 3 seconds in case
of delegated lists.

Assisted-By: Claude Opus 4.7, Claude Code

Co-authored-by: Athul Iddya <athul@iddya.com>
@trop trop Bot added 43-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels May 27, 2026
@ckerr ckerr merged commit 47bc0b5 into 43-x-y May 28, 2026
184 of 189 checks passed
@ckerr ckerr deleted the trop/43-x-y-bp-fix-wait-for-user-selection-on-delegated-lists-in-desktopcapturer-1779901484202 branch May 28, 2026 19:32
@release-clerk

release-clerk Bot commented May 28, 2026

Copy link
Copy Markdown

Release Notes Persisted

Fixed desktopCapturer thumbnail generation and premature portal timeout on Linux with Wayland.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

43-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant