test: make sure there are no orphaned electron processes running#51476
Merged
Conversation
MarshallOfSound
approved these changes
May 4, 2026
|
No Release Notes |
Contributor
|
I was unable to backport this PR to "39-x-y" cleanly; |
Contributor
|
I was unable to backport this PR to "40-x-y" cleanly; |
Contributor
|
I have automatically backported this PR to "41-x-y", please check out #51484 |
Contributor
|
I have automatically backported this PR to "42-x-y", please check out #51485 |
3 tasks
Member
Author
|
/trop run backport-to 40-x-y |
Contributor
|
The backport process for this PR has been manually initiated - sending your PR to |
Contributor
|
I have automatically backported this PR to "40-x-y", please check out #51585 |
6 tasks
jkleinsc
pushed a commit
that referenced
this pull request
May 18, 2026
…#51630) The killOrphanedElectronProcesses beforeAll hook used wmic to find all electron.exe processes by path, excluded only process.pid, then killed the rest. On Windows, GPU/network/renderer helpers share the same exe path — they were being killed as "orphans," causing repeated GPU process crashes until Chromium fataled after 6 restarts. Add a ParentProcessId-based descendant check (matching the existing Linux /proc PPid walk) so child processes of the current instance are preserved. Followup to f9635f7 / #51476.
ckerr
added a commit
that referenced
this pull request
May 19, 2026
…#51685) The killOrphanedElectronProcesses beforeAll hook used wmic to find all electron.exe processes by path, excluded only process.pid, then killed the rest. On Windows, GPU/network/renderer helpers share the same exe path — they were being killed as "orphans," causing repeated GPU process crashes until Chromium fataled after 6 restarts. Add a ParentProcessId-based descendant check (matching the existing Linux /proc PPid walk) so child processes of the current instance are preserved. Followup to f9635f7 / #51476. Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>
ckerr
added a commit
that referenced
this pull request
May 19, 2026
…#51686) The killOrphanedElectronProcesses beforeAll hook used wmic to find all electron.exe processes by path, excluded only process.pid, then killed the rest. On Windows, GPU/network/renderer helpers share the same exe path — they were being killed as "orphans," causing repeated GPU process crashes until Chromium fataled after 6 restarts. Add a ParentProcessId-based descendant check (matching the existing Linux /proc PPid walk) so child processes of the current instance are preserved. Followup to f9635f7 / #51476. Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>
ckerr
added a commit
that referenced
this pull request
May 19, 2026
…#51683) The killOrphanedElectronProcesses beforeAll hook used wmic to find all electron.exe processes by path, excluded only process.pid, then killed the rest. On Windows, GPU/network/renderer helpers share the same exe path — they were being killed as "orphans," causing repeated GPU process crashes until Chromium fataled after 6 restarts. Add a ParentProcessId-based descendant check (matching the existing Linux /proc PPid walk) so child processes of the current instance are preserved. Followup to f9635f7 / #51476. Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>
jkleinsc
pushed a commit
that referenced
this pull request
May 19, 2026
…#51684) The killOrphanedElectronProcesses beforeAll hook used wmic to find all electron.exe processes by path, excluded only process.pid, then killed the rest. On Windows, GPU/network/renderer helpers share the same exe path — they were being killed as "orphans," causing repeated GPU process crashes until Chromium fataled after 6 restarts. Add a ParentProcessId-based descendant check (matching the existing Linux /proc PPid walk) so child processes of the current instance are preserved. Followup to f9635f7 / #51476. Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR updates our test suite to ensure that no orphan Electron processes are running before starting a test spec. This should help to ensure that tests are not affected by earlier tests that happen to leave processes running.
Checklist
npm testpassesRelease Notes
Notes: none