fix: skip current instance's child processes in Windows orphan killer#51630
Merged
Conversation
The killOrphanedElectronProcesses beforeAll hook used wmic to find all electron.exe processes by path, excluded only process.pid, then killed the rest. On Windows, GPU/network/renderer helpers share the same exe path — they were being killed as "orphans," causing repeated GPU process crashes until Chromium fataled after 6 restarts. Add a ParentProcessId-based descendant check (matching the existing Linux /proc PPid walk) so child processes of the current instance are preserved. Followup to f9635f7 / #51476.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
mlaurencin
approved these changes
May 18, 2026
jkleinsc
approved these changes
May 18, 2026
|
No Release Notes |
This was referenced May 18, 2026
Contributor
|
I have automatically backported this PR to "40-x-y", please check out #51683 |
Contributor
|
I have automatically backported this PR to "43-x-y", please check out #51684 |
Contributor
|
I have automatically backported this PR to "41-x-y", please check out #51685 |
Contributor
|
I have automatically backported this PR to "42-x-y", please check out #51686 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixup for f9635f7 / #51476, which updated the test suite to ensure that no orphan Electron processes from a previous test were still running before starting a new test.
That is a good change, but it had a bug that identified some persistent GPU/network/renderer helpers as orphans, causing some tests to fail. In particular, I'm seeing GPU-specific tests fail on Windows arm64 CI.
This PR was co-written with Claude and the fix was tested in downstream CI.
Sample CI failure:
CC @mlaurencin, @jkleinsc
Checklist
npm testpassesRelease Notes
Notes: none.