perf: use GIO for Browser::IsDefaultProtocolClient() on Linux#51316
Merged
Conversation
deepak1556
approved these changes
Apr 27, 2026
codebytere
approved these changes
Apr 27, 2026
perf: use GIO for Browser::SetAsDefaultProtocolClient() on Linux Similar to 7d6227a, this speeds up app.isDefaultProtocolClient() by using the GIO library instead of spawning a shell command to get the info.
3657e75 to
f8f83c6
Compare
jkleinsc
approved these changes
Apr 27, 2026
|
Release Notes Persisted
|
Contributor
|
I was unable to backport this PR to "42-x-y" cleanly; |
7 tasks
Contributor
ckerr
added a commit
that referenced
this pull request
May 19, 2026
* perf: use GIO for Browser::IsDefaultProtocolClient() on Linux perf: use GIO for Browser::SetAsDefaultProtocolClient() on Linux Similar to 7d6227a, this speeds up app.isDefaultProtocolClient() by using the GIO library instead of spawning a shell command to get the info. * feat: log errors if g_app_info_set_as_default_for_type() fails
ckerr
added a commit
that referenced
this pull request
May 20, 2026
* perf: use GIO for Browser::IsDefaultProtocolClient() on Linux perf: use GIO for Browser::SetAsDefaultProtocolClient() on Linux Similar to 7d6227a, this speeds up app.isDefaultProtocolClient() by using the GIO library instead of spawning a shell command to get the info. * feat: log errors if g_app_info_set_as_default_for_type() fails
samuelmaddock
pushed a commit
that referenced
this pull request
May 27, 2026
* perf: use GIO for Browser::IsDefaultProtocolClient() on Linux perf: use GIO for Browser::SetAsDefaultProtocolClient() on Linux Similar to 7d6227a, this speeds up app.isDefaultProtocolClient() by using the GIO library instead of spawning a shell command to get the info. * feat: log errors if g_app_info_set_as_default_for_type() fails
samuelmaddock
added a commit
that referenced
this pull request
May 28, 2026
#51627) * perf: use GIO for Browser::IsDefaultProtocolClient() on Linux (#51316) * perf: use GIO for Browser::IsDefaultProtocolClient() on Linux perf: use GIO for Browser::SetAsDefaultProtocolClient() on Linux Similar to 7d6227a, this speeds up app.isDefaultProtocolClient() by using the GIO library instead of spawning a shell command to get the info. * feat: log errors if g_app_info_set_as_default_for_type() fails * fix: import os --------- Co-authored-by: Samuel Maddock <samuelmaddock@electronjs.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
perf: use GIO for Browser::SetAsDefaultProtocolClient() on Linux
Similar to 7d6227a, this speeds up app.isDefaultProtocolClient() by using the GIO library instead of spawning a shell command to get the info.
Checklist
npm testpassesRelease Notes
Notes: Improved performance of
app.isDefaultProtocolClient()andapp.setAsDefaultProtocolClient()on Linux.