perf: use GIO for Browser::IsDefaultProtocolClient() on Linux (#51316)#51627
Merged
samuelmaddock merged 2 commits intoMay 28, 2026
Merged
Conversation
6 tasks
f753473 to
2174d39
Compare
* perf: use GIO for Browser::IsDefaultProtocolClient() on Linux perf: use GIO for Browser::SetAsDefaultProtocolClient() on Linux Similar to 7d6227a, this speeds up app.isDefaultProtocolClient() by using the GIO library instead of spawning a shell command to get the info. * feat: log errors if g_app_info_set_as_default_for_type() fails
2174d39 to
332d286
Compare
samuelmaddock
approved these changes
May 27, 2026
Member
|
macos test failing due to unrelated changes
|
samuelmaddock
approved these changes
May 28, 2026
MarshallOfSound
approved these changes
May 28, 2026
|
Release Notes Persisted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manually backport #51316 to 42-x-y. See that PR for details.
Notes: Improved performance of
app.isDefaultProtocolClient()andapp.setAsDefaultProtocolClient()on Linux.