Conversation
5e3c141 to
1b6122a
Compare
jkleinsc
requested changes
Feb 17, 2026
Member
jkleinsc
left a comment
There was a problem hiding this comment.
Needs rebase for patch conflicts
1b6122a to
780e720
Compare
780e720 to
0c1ff19
Compare
jkleinsc
approved these changes
Feb 18, 2026
|
Release Notes Persisted
|
Contributor
|
I was unable to backport this PR to "39-x-y" cleanly; |
Contributor
|
I was unable to backport this PR to "41-x-y" cleanly; |
Contributor
|
I was unable to backport this PR to "40-x-y" cleanly; |
Contributor
|
@samuelmaddock has manually backported this PR to "40-x-y", please check out #49856 |
Contributor
|
@samuelmaddock has manually backported this PR to "41-x-y", please check out #49857 |
samuelmaddock
pushed a commit
that referenced
this pull request
Feb 19, 2026
samuelmaddock
pushed a commit
that referenced
this pull request
Feb 19, 2026
Contributor
|
@samuelmaddock has manually backported this PR to "39-x-y", please check out #49861 |
codebytere
added a commit
that referenced
this pull request
Feb 19, 2026
fix: frameless window resize in MAS builds (#49780) Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
3 tasks
kycutler
pushed a commit
to kycutler/electron
that referenced
this pull request
Feb 26, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #49770
This PR adds MAS build compatibility for the resize direction check in
cr_mouseDownOnFrameView.The original code uses the private
_resizeDirectionForMouseLocation:API to determine if a mouse down event is occurring in a window resize area. For MAS builds, we now approximate this behavior by checking if the mouse location is within 5 pixels of any window edge. This isn't a perfect match for what the private API does (which likely accounts for corner radii and other subtleties), but it should cover the common case of preventing window drags from interfering with resize operations.Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where frameless windows had resize issues in Mac App Store builds.