fix: updated Alt detection to explicitly exclude AltGraph/AltGr by darthvader58 · Pull Request #49778 · electron/electron

darthvader58 · 2026-02-11T23:40:58Z

Description of Change

Fixes bug: Pressing AltGr key wrongly interpreted as Alt #49737
Fixed Linux menu-bar focus behavior so AltGr (AltGraph) is no longer treated as a single Alt . Previously, pressing AltGr could trigger menu-bar activation/toggling (especially with auto-hide RootView to explicitly exclude AltGr/AltGraph key events. Also added a Linux regression test in spec/api-browser-window-spec.ts to verify that pressing AltGr does not toggle auto-hide menu bar visibility.

Checklist

PR description included
I have built and tested this PR
npm test passes
tests are changed or added
relevant API documentation, tutorials, and examples are updated and follow the documentation style guide
PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fixed an issue where pressing AltGr could activate or focus the menu bar.

jkleinsc · 2026-02-12T15:25:07Z

@darthvader58 can you rebase your PR with the latest from main? That should fix the lint job failure.

jkleinsc · 2026-02-18T20:54:02Z

@darthvader58 we require commits to be signed before we can merge this PR: https://www.electronjs.org/docs/latest/development/pull-requests#commit-signing. Can you sign your commits?

darthvader58 · 2026-02-19T18:12:54Z

@jkleinsc done

jkleinsc · 2026-02-20T16:21:34Z

@darthvader58 can you rebase one more time? That should resolve the lint CI error.

darthvader58 · 2026-02-20T16:38:09Z

@darthvader58 can you rebase one more time? That should resolve the lint CI error.

@jkleinsc should be good now.

welcome · 2026-02-23T18:00:31Z

Congrats on merging your first pull request! 🎉🎉🎉

release-clerk · 2026-02-23T18:00:31Z

Release Notes Persisted

Fixed an issue where pressing AltGr could activate or focus the menu bar.

Updated Alt detection to explicitly exclude AltGraph/AltGr Co-authored-by: Shashwat Raj <65155843+darthvader58@users.noreply.github.com>

trop · 2026-02-23T18:01:10Z

I have automatically backported this PR to "39-x-y", please check out #49914

trop · 2026-02-23T18:01:16Z

I have automatically backported this PR to "40-x-y", please check out #49915

trop · 2026-02-23T18:01:19Z

I have automatically backported this PR to "41-x-y", please check out #49916

fix: updated Alt detection to explicitly exclude AltGraph/AltGr (#49778) Updated Alt detection to explicitly exclude AltGraph/AltGr Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Shashwat Raj <65155843+darthvader58@users.noreply.github.com>

…tron#49778) Updated Alt detection to explicitly exclude AltGraph/AltGr

…Gr (#49778)" This reverts commit 90c9de7. Ref: #50050

…Gr (#49778)" (#50093) Revert "fix: updated Alt detection to explicitly exclude AltGraph/AltGr (#49778)" This reverts commit 90c9de7. Ref: #50050

…Gr (#49778)" This reverts commit 90c9de7. Ref: #50050 Co-authored-by: clavin <clavin@electronjs.org>

…Gr (#49778)" (#50111) Revert "fix: updated Alt detection to explicitly exclude AltGraph/AltGr (#49778)" This reverts commit 90c9de7. Ref: #50050 Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: clavin <clavin@electronjs.org>

…Gr (#49778)" (#50110) Revert "fix: updated Alt detection to explicitly exclude AltGraph/AltGr (#49778)" This reverts commit 90c9de7. Ref: #50050 Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: clavin <clavin@electronjs.org>

…50109) Revert "fix: updated Alt detection to explicitly exclude AltGraph/AltGr (#49778)" This reverts commit 90c9de7. Ref: #50050 Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: clavin <clavin@electronjs.org>

electron-cation bot added the new-pr 🌱 PR opened recently label Feb 11, 2026

jkleinsc added the semver/patch backwards-compatible bug fixes label Feb 12, 2026

jkleinsc changed the title ~~Updated Alt detection to explicitly exclude AltGraph/AltGr~~ fix: updated Alt detection to explicitly exclude AltGraph/AltGr Feb 12, 2026

jkleinsc added target/39-x-y PR should also be added to the "39-x-y" branch. target/41-x-y PR should also be added to the "41-x-y" branch. labels Feb 12, 2026

jkleinsc added the target/40-x-y PR should also be added to the "40-x-y" branch. label Feb 12, 2026

electron-cation bot removed the new-pr 🌱 PR opened recently label Feb 12, 2026

jkleinsc approved these changes Feb 18, 2026

View reviewed changes

Updated Alt detection to explicitly exclude AltGraph/AltGr

b54c6ae

darthvader58 force-pushed the main branch from aaa0737 to b54c6ae Compare February 19, 2026 18:10

Merge branch 'electron:main' into main

fc3edd8

codebytere approved these changes Feb 23, 2026

View reviewed changes

jkleinsc merged commit 90c9de7 into electron:main Feb 23, 2026
108 of 109 checks passed

trop bot added a commit that referenced this pull request Feb 23, 2026

fix: updated Alt detection to explicitly exclude AltGraph/AltGr (#49778)

a7a2794

Updated Alt detection to explicitly exclude AltGraph/AltGr Co-authored-by: Shashwat Raj <65155843+darthvader58@users.noreply.github.com>

trop bot added a commit that referenced this pull request Feb 23, 2026

fix: updated Alt detection to explicitly exclude AltGraph/AltGr (#49778)

12a7676

Updated Alt detection to explicitly exclude AltGraph/AltGr Co-authored-by: Shashwat Raj <65155843+darthvader58@users.noreply.github.com>

trop bot mentioned this pull request Feb 23, 2026

fix: updated Alt detection to explicitly exclude AltGraph/AltGr #49914

Merged

trop bot added a commit that referenced this pull request Feb 23, 2026

fix: updated Alt detection to explicitly exclude AltGraph/AltGr (#49778)

ef15e80

Updated Alt detection to explicitly exclude AltGraph/AltGr Co-authored-by: Shashwat Raj <65155843+darthvader58@users.noreply.github.com>

This was referenced Feb 23, 2026

fix: updated Alt detection to explicitly exclude AltGraph/AltGr #49915

Merged

fix: updated Alt detection to explicitly exclude AltGraph/AltGr #49916

Merged

trop bot added the in-flight/39-x-y label Feb 23, 2026

trop bot removed the target/39-x-y PR should also be added to the "39-x-y" branch. label Feb 23, 2026

trop bot added in-flight/40-x-y in-flight/41-x-y and removed target/40-x-y PR should also be added to the "40-x-y" branch. target/41-x-y PR should also be added to the "41-x-y" branch. labels Feb 23, 2026

trop bot added merged/41-x-y PR was merged to the "41-x-y" branch. and removed in-flight/41-x-y labels Feb 23, 2026

trop bot added merged/40-x-y PR was merged to the "40-x-y" branch. and removed in-flight/40-x-y labels Feb 23, 2026

trop bot added merged/39-x-y PR was merged to the "39-x-y" branch. and removed in-flight/39-x-y labels Feb 23, 2026

kycutler pushed a commit to kycutler/electron that referenced this pull request Feb 26, 2026

fix: updated Alt detection to explicitly exclude AltGraph/AltGr (elec…

2f9bc79

…tron#49778) Updated Alt detection to explicitly exclude AltGraph/AltGr

nikwen mentioned this pull request Mar 4, 2026

autoHideMenuBar: Alt key no longer toggles menu bar on Windows (regression since v39.7.0 / v40.6.1) #50050

Closed

3 tasks

mstroeve mentioned this pull request Mar 5, 2026

Left Alt key no longer toggles autoHideMenuBar after AltGr fix (#49778) #50082

Closed

3 tasks

clavin added a commit that referenced this pull request Mar 5, 2026

Revert "fix: updated Alt detection to explicitly exclude AltGraph/Alt…

cd7c78e

…Gr (#49778)" This reverts commit 90c9de7. Ref: #50050

trop bot added a commit that referenced this pull request Mar 6, 2026

Revert "fix: updated Alt detection to explicitly exclude AltGraph/Alt…

41aca21

…Gr (#49778)" This reverts commit 90c9de7. Ref: #50050 Co-authored-by: clavin <clavin@electronjs.org>

trop bot added a commit that referenced this pull request Mar 6, 2026

Revert "fix: updated Alt detection to explicitly exclude AltGraph/Alt…

1b6d12d

…Gr (#49778)" This reverts commit 90c9de7. Ref: #50050 Co-authored-by: clavin <clavin@electronjs.org>

trop bot added a commit that referenced this pull request Mar 6, 2026

Revert "fix: updated Alt detection to explicitly exclude AltGraph/Alt…

f9e5a66

…Gr (#49778)" This reverts commit 90c9de7. Ref: #50050 Co-authored-by: clavin <clavin@electronjs.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: updated Alt detection to explicitly exclude AltGraph/AltGr#49778

fix: updated Alt detection to explicitly exclude AltGraph/AltGr#49778
jkleinsc merged 2 commits intoelectron:mainfrom
darthvader58:main

darthvader58 commented Feb 11, 2026 •

edited by jkleinsc

Loading

Uh oh!

jkleinsc commented Feb 12, 2026

Uh oh!

jkleinsc commented Feb 18, 2026

Uh oh!

darthvader58 commented Feb 19, 2026

Uh oh!

jkleinsc commented Feb 20, 2026

Uh oh!

darthvader58 commented Feb 20, 2026 •

edited

Loading

Uh oh!

Uh oh!

welcome bot commented Feb 23, 2026

Uh oh!

release-clerk bot commented Feb 23, 2026

Uh oh!

trop bot commented Feb 23, 2026

Uh oh!

trop bot commented Feb 23, 2026

Uh oh!

trop bot commented Feb 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

darthvader58 commented Feb 11, 2026 • edited by jkleinsc Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Change

Checklist

Release Notes

Uh oh!

jkleinsc commented Feb 12, 2026

Uh oh!

jkleinsc commented Feb 18, 2026

Uh oh!

darthvader58 commented Feb 19, 2026

Uh oh!

jkleinsc commented Feb 20, 2026

Uh oh!

darthvader58 commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

welcome bot commented Feb 23, 2026

Uh oh!

release-clerk bot commented Feb 23, 2026

Uh oh!

trop bot commented Feb 23, 2026

Uh oh!

trop bot commented Feb 23, 2026

Uh oh!

trop bot commented Feb 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

darthvader58 commented Feb 11, 2026 •

edited by jkleinsc

Loading

darthvader58 commented Feb 20, 2026 •

edited

Loading