Skip to content

fix: Revert "updated Alt detection to explicitly exclude AltGraph/AltGr (#49778)"#50093

Merged
jkleinsc merged 1 commit intomainfrom
clavin--revert-altgr
Mar 6, 2026
Merged

fix: Revert "updated Alt detection to explicitly exclude AltGraph/AltGr (#49778)"#50093
jkleinsc merged 1 commit intomainfrom
clavin--revert-altgr

Conversation

@clavin
Copy link
Copy Markdown
Member

@clavin clavin commented Mar 5, 2026

Description of Change

This reverts commit 90c9de7.

Closes #50050
Reopens #49737

Checklist

Release Notes

Notes: Reverted AltGr key fix that caused menu bar to no longer show on Windows.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Mar 5, 2026
@clavin clavin added target/39-x-y PR should also be added to the "39-x-y" branch. target/40-x-y PR should also be added to the "40-x-y" branch. target/41-x-y PR should also be added to the "41-x-y" branch. semver/patch backwards-compatible bug fixes labels Mar 5, 2026
@clavin clavin changed the title Revert "fix: updated Alt detection to explicitly exclude AltGraph/AltGr (#49778)" fix: Revert "updated Alt detection to explicitly exclude AltGraph/AltGr (#49778)" Mar 5, 2026
nikwen
nikwen approved these changes Mar 5, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@nikwen nikwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@clavin
Copy link
Copy Markdown
Member Author

clavin commented Mar 5, 2026

Noting here for posterity: We're reverting this bc the Electron 41 release is next week, and reopening the original issue.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Mar 6, 2026
@jkleinsc jkleinsc merged commit 73596cf into main Mar 6, 2026
79 checks passed
@jkleinsc jkleinsc deleted the clavin--revert-altgr branch March 6, 2026 20:25
@release-clerk
Copy link
Copy Markdown

release-clerk bot commented Mar 6, 2026

Release Notes Persisted

Reverted AltGr key fix that caused menu bar to no longer show on Windows.

This was referenced Mar 6, 2026
Merged
Merged
@trop
Copy link
Copy Markdown
Contributor

trop bot commented Mar 6, 2026

I have automatically backported this PR to "39-x-y", please check out #50109

@trop trop bot added the in-flight/39-x-y label Mar 6, 2026
@trop trop bot mentioned this pull request Mar 6, 2026
Merged
@trop trop bot removed the target/39-x-y PR should also be added to the "39-x-y" branch. label Mar 6, 2026
@trop
Copy link
Copy Markdown
Contributor

trop bot commented Mar 6, 2026

I have automatically backported this PR to "40-x-y", please check out #50110

@trop
Copy link
Copy Markdown
Contributor

trop bot commented Mar 6, 2026

I have automatically backported this PR to "41-x-y", please check out #50111

@trop trop bot added in-flight/40-x-y in-flight/41-x-y merged/41-x-y PR was merged to the "41-x-y" branch. and removed target/40-x-y PR should also be added to the "40-x-y" branch. target/41-x-y PR should also be added to the "41-x-y" branch. in-flight/41-x-y labels Mar 6, 2026
@trop trop bot added merged/40-x-y PR was merged to the "40-x-y" branch. merged/39-x-y PR was merged to the "39-x-y" branch. and removed in-flight/40-x-y in-flight/39-x-y labels Mar 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ckerr ckerr ckerr approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

@nikwen nikwen nikwen approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees

No one assigned

Labels

merged/39-x-y PR was merged to the "39-x-y" branch. merged/40-x-y PR was merged to the "40-x-y" branch. merged/41-x-y PR was merged to the "41-x-y" branch. semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

autoHideMenuBar: Alt key no longer toggles menu bar on Windows (regression since v39.7.0 / v40.6.1)

5 participants

@clavin @ckerr @jkleinsc @nikwen @VerteDinde