Skip to content

fix: crash when closing devtools after focus#47435

Merged
codebytere merged 1 commit into
mainfrom
fix-close-crash
Apr 14, 2026
Merged

fix: crash when closing devtools after focus#47435
codebytere merged 1 commit into
mainfrom
fix-close-crash

Conversation

@codebytere

@codebytere codebytere commented Jun 10, 2025

Copy link
Copy Markdown
Member

Description of Change

Closes #19985.

Fixes an issue where closing devtools immediately after focus causes a crash. The crash happened because closing DevTools immediately destroys the DevTools WebContents while the main WebContents is still notifying observers for the focus event, which is prohibited.

Checklist

Release Notes

Notes: Fixed an issue where closing devtools immediately after focus caused a crash.

@codebytere codebytere requested review from ckerr and deepak1556 June 10, 2025 15:53
@electron-cation electron-cation Bot added the new-pr 🌱 PR opened recently label Jun 10, 2025
@codebytere codebytere added semver/patch backwards-compatible bug fixes target/35-x-y PR should also be added to the "35-x-y" branch. target/36-x-y PR should also be added to the "36-x-y" branch. target/37-x-y PR should also be added to the "37-x-y" branch. labels Jun 10, 2025
deepak1556
deepak1556 reviewed Jun 10, 2025
View reviewed changes
Comment thread shell/browser/ui/inspectable_web_contents.cc Outdated
Comment thread shell/browser/api/electron_api_web_contents.cc
Comment thread shell/browser/ui/inspectable_web_contents.cc Outdated
Comment thread shell/browser/ui/inspectable_web_contents.cc
@electron-cation electron-cation Bot removed the new-pr 🌱 PR opened recently label Jun 11, 2025
@codebytere codebytere force-pushed the fix-close-crash branch 3 times, most recently from 8d2f6e4 to bd6d7e8 Compare June 17, 2025 16:25
@github-actions github-actions Bot added the target/38-x-y PR should also be added to the "38-x-y" branch. label Jun 24, 2025
@codebytere codebytere force-pushed the fix-close-crash branch 2 times, most recently from 20e715b to c4caa9b Compare August 11, 2025 08:38
@github-actions github-actions Bot added the target/39-x-y PR should also be added to the "39-x-y" branch. label Sep 3, 2025
@jkleinsc jkleinsc added wip ⚒ and removed target/35-x-y PR should also be added to the "35-x-y" branch. labels Oct 23, 2025
@jkleinsc

jkleinsc commented Oct 23, 2025

Copy link
Copy Markdown
Member

@codebytere moving to WIP until you can get back to this.

@github-actions github-actions Bot added the target/40-x-y PR should also be added to the "40-x-y" branch. label Oct 28, 2025
@github-actions github-actions Bot added the target/41-x-y PR should also be added to the "41-x-y" branch. label Jan 19, 2026
@github-actions github-actions Bot added the target/42-x-y PR should also be added to the "42-x-y" branch. label Mar 13, 2026
@codebytere codebytere removed target/36-x-y PR should also be added to the "36-x-y" branch. target/37-x-y PR should also be added to the "37-x-y" branch. target/38-x-y PR should also be added to the "38-x-y" branch. target/39-x-y PR should also be added to the "39-x-y" branch. labels Apr 7, 2026
@codebytere codebytere force-pushed the fix-close-crash branch 4 times, most recently from 60a0afc to 961857e Compare April 9, 2026 08:21
@codebytere codebytere removed the wip ⚒ label Apr 9, 2026
@jkleinsc jkleinsc requested a review from deepak1556 April 13, 2026 19:34
@codebytere codebytere merged commit 2e3da1d into main Apr 14, 2026
112 of 115 checks passed
@codebytere codebytere deleted the fix-close-crash branch April 14, 2026 10:32
@release-clerk

release-clerk Bot commented Apr 14, 2026

Copy link
Copy Markdown

Release Notes Persisted

Fixed an issue where closing devtools immediately after focus caused a crash.

@trop

trop Bot commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

I was unable to backport this PR to "40-x-y" cleanly;
you will need to perform this backport manually.

@trop trop Bot added needs-manual-bp/40-x-y and removed target/40-x-y PR should also be added to the "40-x-y" branch. labels Apr 14, 2026
@trop trop Bot mentioned this pull request Apr 14, 2026
Merged
@trop

trop Bot commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

I have automatically backported this PR to "42-x-y", please check out #51036

@trop trop Bot mentioned this pull request Apr 14, 2026
Merged
@trop trop Bot removed the target/42-x-y PR should also be added to the "42-x-y" branch. label Apr 14, 2026
@trop

trop Bot commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

I have automatically backported this PR to "41-x-y", please check out #51037

@trop trop Bot added in-flight/41-x-y merged/42-x-y PR was merged to the "42-x-y" branch. merged/41-x-y PR was merged to the "41-x-y" branch. and removed target/41-x-y PR should also be added to the "41-x-y" branch. in-flight/42-x-y in-flight/41-x-y labels Apr 14, 2026
@ckerr ckerr mentioned this pull request May 19, 2026
Merged
@trop

trop Bot commented May 19, 2026

Copy link
Copy Markdown
Contributor

@ckerr has manually backported this PR to "40-x-y", please check out #51702

jkleinsc pushed a commit that referenced this pull request May 20, 2026
@ckerr @codebytere
fix: crash when closing devtools after focus (#51702)
7586b48 
fix: crash when closing devtools after focus (#47435)

(cherry picked from commit 2e3da1d)
Co-authored-by: Charles Kerr <charles@charleskerr.com>

# Conflicts:
#	shell/browser/ui/inspectable_web_contents.cc

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
@trop trop Bot added merged/40-x-y PR was merged to the "40-x-y" branch. and removed in-flight/40-x-y labels May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@ckerr ckerr Awaiting requested review from ckerr

Assignees

No one assigned

Labels

merged/40-x-y PR was merged to the "40-x-y" branch. merged/41-x-y PR was merged to the "41-x-y" branch. merged/42-x-y PR was merged to the "42-x-y" branch. semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Crash when closing devtools after focus

3 participants

@codebytere @jkleinsc @deepak1556