Skip to content

fix: crash when closing devtools after focus#51702

Merged
jkleinsc merged 1 commit into
40-x-yfrom
fix/devtools-close-crash--40-x-y
May 20, 2026
Merged

fix: crash when closing devtools after focus#51702
jkleinsc merged 1 commit into
40-x-yfrom
fix/devtools-close-crash--40-x-y

Conversation

@ckerr

@ckerr ckerr commented May 19, 2026

Copy link
Copy Markdown
Member

Manually backport #47435 to 40-x-y. See that PR for details.

Notes: Fixed an issue where closing devtools immediately after focus caused a crash.

Manually backported + tested with e test -g 'does not crash when closing DevTools immediately after opening'

(cherry picked from commit 2e3da1d)
Co-authored-by: Charles Kerr <charles@charleskerr.com>

# Conflicts:
#	shell/browser/ui/inspectable_web_contents.cc
@ckerr ckerr added component/devtools backport This is a backport PR semver/patch backwards-compatible bug fixes no-backport 40-x-y labels May 19, 2026
@ckerr ckerr marked this pull request as draft May 19, 2026 19:31
@ckerr ckerr marked this pull request as ready for review May 20, 2026 02:14
@jkleinsc jkleinsc merged commit 7586b48 into 40-x-y May 20, 2026
129 of 131 checks passed
@jkleinsc jkleinsc deleted the fix/devtools-close-crash--40-x-y branch May 20, 2026 13:51
@release-clerk

release-clerk Bot commented May 20, 2026

Copy link
Copy Markdown

Release Notes Persisted

Fixed an issue where closing devtools immediately after focus caused a crash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

40-x-y backport This is a backport PR component/devtools no-backport semver/patch backwards-compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants