feat: add support for --experimental-network-inspection#46690
feat: add support for --experimental-network-inspection#46690jkleinsc merged 3 commits intoelectron:mainfrom
--experimental-network-inspection#46690Conversation
|
💖 Thanks for opening this pull request! 💖 Semantic PR titlesWe use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Commit signingThis repo enforces commit signatures for all incoming PRs. PR tipsThings that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
4e877b3 to
06d18b8
Compare
MarshallOfSound
left a comment
There was a problem hiding this comment.
Specifically approving the concept of this from a security standpoint given the fuse implication, this is correctly gated behind the debug fuse and as such doesn't expose substantially more surface area IMO.
patches/node/inspector_add_network_initiator_in_inspector_protocol.patch
Outdated
Show resolved
Hide resolved
|
Was able to build this locally and confirm it works. // main.ts
const child = utilityProcess.fork(forkPath, [], {
execArgv: ['--experimental-network-inspection']
})// fork.ts
import https from 'node:https';
setInterval(function() {
https.get('https://encrypted.google.com/', (res) => {
console.log('statusCode:', res.statusCode);
console.log('headers:', res.headers);
}).on('error', (e) => {
console.error(e);
});
}, 5000)
response bodies are not visible, but request call stacks works. |
jkleinsc
left a comment
There was a problem hiding this comment.
https://github.com/electron/electron/blob/main/docs/api/command-line-switches.md#nodejs-flags should be updated to include the new flag --experimental-network-inspection
jkleinsc
left a comment
There was a problem hiding this comment.
@tmm1 looks good, but you need to sign your commits before we can merge this:
This repo enforces commit signatures for all incoming PRs.
To sign your commits, see GitHub's documentation on Telling Git about your signing key.
f054a1a to
4ef9f04
Compare
Sorry, I think I fixed it. |
| From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 | ||
| From: Chengzhong Wu <cwu631@bloomberg.net> | ||
| Date: Wed, 5 Feb 2025 18:03:57 +0000 | ||
| Subject: inspector: add Network.Initiator in inspector protocol |
There was a problem hiding this comment.
This patch landed in node v22.15.0, so it will be unnecessary when that dependency is bumped.
There was a problem hiding this comment.
I removed this patch here, since it will get pulled in later. That makes this PR much simpler and easier to backport.
|
Not sure why the builds here keep timing out? I can rebase to the latest main branch. |
|
Release Notes Persisted
|
|
I have automatically backported this PR to "35-x-y", please check out #47029 |
|
I have automatically backported this PR to "36-x-y", please check out #47030 |
|
I have automatically backported this PR to "37-x-y", please check out #47031 |
…6690) * feat: add support for `--experimental-network-inspection` * docs: fix minor formatting issues visible on both GH[1] and the docs site[2] [1] https://github.com/electron/electron/blob/main/docs/api/command-line-switches.md#nodejs-flags [2] https://www.electronjs.org/docs/latest/api/command-line-switches#--inspect-brkhostport * docs: add entry for new nodejs flag
Description of Change
Allow
--experimental-network-inspectionto be used in NODE_OPTIONS.Includes nodejs/node#56805
cc @deepak1556
Checklist
npm testpassesRelease Notes
Notes: Added support for node option
--experimental-network-inspection