feat: add support for --experimental-network-inspection (34-x-y)#46691
Closed
tmm1 wants to merge 1 commit intoelectron:34-x-yfrom
Closed
feat: add support for --experimental-network-inspection (34-x-y)#46691tmm1 wants to merge 1 commit intoelectron:34-x-yfrom
--experimental-network-inspection (34-x-y)#46691tmm1 wants to merge 1 commit intoelectron:34-x-yfrom
Conversation
5 tasks
MarshallOfSound
requested changes
Apr 20, 2025
Member
MarshallOfSound
left a comment
There was a problem hiding this comment.
Please don't raise backport PRs until the original is approved.
As an aside IMO it is unlikely that we accept a 2000 line patch to node in v34 specifically, our rule is that it should be consistent which means that v35 and v36 should receive it too. And the sheer size of this patch is IMO too much to accept
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #46690