fix: backgroundMaterial on initial activate#46657
Merged
codebytere merged 2 commits intomainfrom Apr 17, 2025
Merged
Conversation
backgroundMaterial on initial activate
clavin
approved these changes
Apr 16, 2025
ckerr
reviewed
Apr 16, 2025
patches/chromium/fix_activate_background_material_on_windows.patch
Outdated
Show resolved
Hide resolved
…atch Co-authored-by: Charles Kerr <charles@charleskerr.com>
7a9f916 to
32561d9
Compare
|
Release Notes Persisted
|
Contributor
|
I was unable to backport this PR to "35-x-y" cleanly; |
Contributor
|
I was unable to backport this PR to "36-x-y" cleanly; |
ckerr
pushed a commit
that referenced
this pull request
Apr 25, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
ckerr
added a commit
that referenced
this pull request
Apr 26, 2025
* fix: `backgroundMaterial` on initial activate (#46657) * empty commit --------- Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
3 tasks
3 tasks
Contributor
kigh-ota
pushed a commit
to kigh-ota/electron
that referenced
this pull request
Sep 30, 2025
* fix: backgroundMaterial on initial activate Closes electron#38466 * Update patches/chromium/fix_activate_background_material_on_windows.patch Co-authored-by: Charles Kerr <charles@charleskerr.com> --------- Co-authored-by: Charles Kerr <charles@charleskerr.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #38466
Extends #39708 to fix an issue where the
backgroundMaterialfeature did not work in a frameless window on initial window creation. A repaint needed to be triggered first, by a resize or other similar action.Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where the
backgroundMaterialfeature did not work in a frameless window on initial window creation.