fix: frameless mica/acrylic windows#39708
Merged
codebytere merged 7 commits intomainfrom Sep 11, 2023
Merged
Conversation
zcbenz
approved these changes
Sep 7, 2023
| with translucent background materials to become activated. | ||
|
|
||
| This patch likely can't be upstreamed as-is, as Chromium doesn't have | ||
| this use case in mind currently. |
Contributor
There was a problem hiding this comment.
I think for a simple patch like this there is a chance upstreaming it, read the change log of the file and find the maintainer who has done related modifications, and ask them to review.
jkleinsc
approved these changes
Sep 7, 2023
samuelmaddock
approved these changes
Sep 7, 2023
VerteDinde
approved these changes
Sep 7, 2023
Member
VerteDinde
left a comment
There was a problem hiding this comment.
Tested this on Windows - the transparency seems to be working as expected. I'm also fine merging this as is and potentially upstreaming the patch later
|
Release Notes Persisted
|
Contributor
|
I have automatically backported this PR to "27-x-y", please check out #39802 |
3 tasks
|
Great, I hope to merge into Electron 26 soon. |
Contributor
3 tasks
5 tasks
5 tasks
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
* fix: backgroundMaterial works with frameless * TODO: fix frameless mica/acrylic windows * update caption color appropriately * set background color properly * refactor translucency method * actualization
5 tasks
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #38532
Checklist
npm testpassesRelease Notes
Notes: Fixed Windows Mica/Acrylic background material effects on frameless windows.